Skip to content

Commit 5ff71e0

Browse files
committed
remove unnecessary comment
Signed-off-by: Matt Katz <[email protected]>
1 parent 117ed53 commit 5ff71e0

1 file changed

Lines changed: 1 addition & 9 deletions

File tree

  • encodings/fastlanes/src/for/compute

‎encodings/fastlanes/src/for/compute/cast.rs‎

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,7 @@ use crate::r#for::array::FoRArrayExt;
1414
use crate::r#for::array::FoRArraySlotsExt;
1515
impl CastReduce for FoR {
1616
fn cast(array: ArrayView<'_, Self>, dtype: &DType) -> VortexResult<Option<ArrayRef>> {
17-
// Only a nullability change is pushed down: it leaves the values, and so the non-nullable
18-
// references, as they are.
19-
//
20-
// Changing the type would cast the encoded values as values, but they are offsets from the
21-
// reference modulo 2^n. E.g. `i8` values -128..=127 have the reference -128, so 127 is
22-
// stored as 255, which wraps to -1, and would decode as -129 in `i16`. Decline, so the
23-
// decoded values are cast instead.
17+
// Only push down nullability change.
2418
if !array.dtype().eq_ignore_nullability(dtype) {
2519
return Ok(None);
2620
}
@@ -106,8 +100,6 @@ mod tests {
106100
);
107101
}
108102

109-
/// A type change decodes first, rather than casting the FoR offsets as values. `None` expects an
110-
/// error.
111103
#[rstest]
112104
// 127 is stored as 255, which wraps to -1 in `i8`, and would decode as -129 in `i16`.
113105
#[case::widen_wrapped_offset(

0 commit comments

Comments
 (0)