Skip to content

Commit 58d0f86

Browse files
committed
Fix temporal validation test fixtures in Python and Java
Signed-off-by: Connor Tsui <[email protected]>
1 parent afd1d5e commit 58d0f86

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎java/vortex-jni/src/test/java/dev/vortex/api/ExpressionTagParityTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ public void timestampAcceptsEveryUnitExceptDays() {
164164
RuntimeException exception =
165165
assertThrows(RuntimeException.class, () -> Expression.literalTimestamp(0L, TimeUnit.DAYS, "UTC"));
166166
assertTrue(
167-
exception.getMessage().contains("Timestamp does not support Days time unit"),
167+
exception.getMessage().contains("Timestamp time unit must be finer than days, got Days"),
168168
() -> "unexpected message: " + exception.getMessage());
169169
}
170170

‎vortex-python/test/test_scalar.py‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,12 @@ class InvalidTimezone(datetime.tzinfo):
305305
def utcoffset(self, dt: datetime.datetime | None) -> datetime.timedelta:
306306
return datetime.timedelta(0)
307307

308+
def dst(self, dt: datetime.datetime | None) -> datetime.timedelta:
309+
return datetime.timedelta(0)
310+
311+
def tzname(self, dt: datetime.datetime | None) -> str:
312+
return self.key
313+
308314
value = datetime.datetime(1970, 1, 1, tzinfo=InvalidTimezone())
309315
with pytest.raises(RuntimeError, match="Not/A/Timezone"):
310316
vx.scalar(value)

0 commit comments

Comments
 (0)