Skip to content

Commit 55028ca

Browse files
committed
Reduce syscall noise in Python scan benchmarks
Signed-off-by: Connor Tsui <[email protected]>
1 parent c6d6bad commit 55028ca

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

‎.github/workflows/codspeed.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,9 @@ jobs:
185185
uses: CodSpeedHQ/action@78102a468f96d8e0ccb92d0ec49425753fc42062 # v5
186186
env:
187187
VORTEX_BENCH_DATA_DIR: ${{ runner.temp }}/vortex-bench-data
188+
# Drive scans on the calling thread. Background workers wake every 100 ms to check
189+
# for shutdown. Under simulation, those timer wakeups can dominate the measured work.
190+
VORTEX_MAX_THREADS: "0"
188191
with:
189192
run: cd vortex-python && uv run --all-packages --no-sync pytest benchmark/ --codspeed
190193
token: ${{ secrets.CODSPEED_TOKEN }}

‎vortex-python/benchmark/conftest.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,5 @@ def vxf(
1818
directory = os.environ.get("VORTEX_BENCH_DATA_DIR")
1919
path = data.write(Path(directory) if directory else tmp_path_factory.getbasetemp() / "data", request.param)
2020

21-
return vx.open(str(path))
21+
# Measure scan and decode CPU work without dispatching file reads to IO threads.
22+
return vx.open(str(path), memory_map=True)

0 commit comments

Comments
 (0)