Repository navigation
Commit 4fdf68a
docs: make the 1 ms benchmark iteration budget an explicit maximum
The guide asked for "less than 1ms" without saying whether that was a target or a limit,
and without saying which number to measure. Benchmarks have landed at 23.8 ms and 123.4 ms
per iteration, and the review conversation on those has no documented rule to point at.
State that 1 ms is the maximum, say what to do when a benchmark does not fit, and point at
CodSpeed's per-iteration number under HEAD as the value to check -- not the runtime of the
whole benchmark binary, which is what "too long" usually gets confused with.
Signed-off-by: Joe Isaacs <[email protected]>
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01FZJAp4wVgwTVhLyErCWFZn1 parent fd43ebd commit 4fdf68a
1 file changed
Lines changed: 13 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
| 122 | + | |
123 | 123 | | |
124 | | - | |
125 | | - | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
126 | 136 | | |
127 | 137 | | |
128 | 138 | | |
| |||
0 commit comments