Skip to content

Commit 4e054c4

Browse files
committed
Note that the non-canonical decimal Interleave copy goes away
Once every `DecimalArray` stores its values at the canonical width of its dtype (#10701), all sources of a decimal `Interleave` share that width and the copy branch cannot run. Signed-off-by: Connor Tsui <[email protected]>
1 parent c0eb004 commit 4e054c4

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

  • vortex-array/src/arrays/interleave/execute

‎vortex-array/src/arrays/interleave/execute/decimal.rs‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,10 @@ fn prepare_source<T: NativeDecimalType>(
8585
let data = if decimal.values_type() == T::DECIMAL_TYPE {
8686
decimal.buffer::<T>()
8787
} else {
88-
// A source can still store its values at a width other than the canonical width of its
89-
// dtype (#10701). The copy widens such values, or checks their precision and narrows them
88+
// TODO(connor): Remove this branch once every `DecimalArray` stores its values at the
89+
// canonical width of its dtype (#10701). Then all sources share the canonical width `T`,
90+
// because they share the dtype up to nullability. Until then, a source can store its values
91+
// at another width. The copy widens such values, or checks their precision and narrows them
9092
// with zeros in the null slots.
9193
let mask = decimal.validity()?.execute_mask(value.len(), ctx)?;
9294
let copy = match_each_decimal_value_type!(decimal.values_type(), |S| {

0 commit comments

Comments
 (0)