Skip to content

Commit 4a7c257

Browse files
faster codspeed (#6628)
<!-- Thank you for submitting a pull request! We appreciate your time and effort. Please make sure to provide enough information so that we can review your pull request. The Summary and Testing sections below contain guidance on what to include. --> ## Summary <!-- If this PR is related to a tracked effort, please link to the relevant issue here (e.g., `Closes: #123`). Otherwise, feel free to ignore / delete this. In this section, please: 1. Explain the rationale for this change. 2. Summarize the changes included in this PR. A general rule of thumb is that larger PRs should have larger summaries. If there are a lot of changes, please help us review the code by explaining what was changed and why. If there is an issue or discussion attached, there is no need to duplicate all the details, but clarity is always preferred over brevity. --> Closes: #000 <!-- ## API Changes Uncomment this section if there are any user-facing changes. Consider whether the change affects users in one of the following ways: 1. Breaks public APIs in some way. 2. Changes the underlying behavior of one of the engine integrations. 3. Should some documentation be updated to reflect this change? If a public API is changed in a breaking manner, make sure to add the appropriate label. You can run `./scripts/public-api.sh` locally to see if there are any public API changes (and this also runs in our CI). --> ## Testing <!-- Please describe how this change was tested. Here are some common categories for testing in Vortex: 1. Verifying existing behavior is maintained. 2. Verifying new behavior and functionality works correctly. 3. Serialization compatibility (backwards and forwards) should be maintained or explicitly broken. --> --------- Signed-off-by: Joe Isaacs <[email protected]>
1 parent 80a5175 commit 4a7c257

3 files changed

Lines changed: 8 additions & 14 deletions

File tree

‎vortex-array/benches/dict_compress.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,11 @@ const BENCH_ARGS: &[(usize, usize)] = &[
2525
(1_000, 4),
2626
(1_000, 8),
2727
(1_000, 32),
28-
(1_000, 128),
2928
(1_000, 512),
3029
(10_000, 2),
3130
(10_000, 4),
3231
(10_000, 8),
3332
(10_000, 32),
34-
(10_000, 128),
3533
(10_000, 512),
3634
];
3735

‎vortex-array/benches/listview_rebuild.rs‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -95,11 +95,11 @@ fn make_struct_lv(num_lists: usize, list_size: usize, step: usize) -> ListViewAr
9595
}
9696

9797
// ── i32 with varied list sizes ───────────────────────────────────────────────
98-
const LIST_SIZES: &[usize] = &[512, 1024, 2048];
98+
const LIST_SIZES: &[usize] = &[512, 2048];
9999

100100
#[divan::bench(args = LIST_SIZES)]
101101
fn i32_varied_list_sizes(bencher: Bencher, list_size: usize) {
102-
let lv = make_primitive_lv(1_000, list_size, list_size);
102+
let lv = make_primitive_lv(100, list_size, list_size);
103103
bencher
104104
.with_inputs(|| &lv)
105105
.bench_refs(|lv| lv.rebuild(ListViewRebuildMode::MakeZeroCopyToList).unwrap());
@@ -108,7 +108,7 @@ fn i32_varied_list_sizes(bencher: Bencher, list_size: usize) {
108108
// ── i8 with 65K-element lists ─────────────────────────────────────────────────
109109
#[divan::bench]
110110
fn i8_large_lists(bencher: Bencher) {
111-
let lv = make_i8_lv(1_000, 65_536, 65_536);
111+
let lv = make_i8_lv(10, 65_536, 65_536);
112112
bencher
113113
.with_inputs(|| &lv)
114114
.bench_refs(|lv| lv.rebuild(ListViewRebuildMode::MakeZeroCopyToList).unwrap());
@@ -117,7 +117,7 @@ fn i8_large_lists(bencher: Bencher) {
117117
// ── i32 with 8-element overlapping lists ──────────────────────────────────────
118118
#[divan::bench]
119119
fn i32_small_overlapping(bencher: Bencher) {
120-
let lv = make_primitive_lv(1_000, 8, 1);
120+
let lv = make_primitive_lv(100, 8, 1);
121121
bencher
122122
.with_inputs(|| &lv)
123123
.bench_refs(|lv| lv.rebuild(ListViewRebuildMode::MakeZeroCopyToList).unwrap());
@@ -126,7 +126,7 @@ fn i32_small_overlapping(bencher: Bencher) {
126126
// ── VarBinView: variable-width elements ──────────────────────────────────────
127127
#[divan::bench]
128128
fn varbinview_rebuild(bencher: Bencher) {
129-
let lv = make_varbinview_lv(1_000, 1_024, 1_024);
129+
let lv = make_varbinview_lv(100, 1_024, 1_024);
130130
bencher
131131
.with_inputs(|| &lv)
132132
.bench_refs(|lv| lv.rebuild(ListViewRebuildMode::MakeZeroCopyToList).unwrap());
@@ -144,7 +144,7 @@ fn struct_rebuild(bencher: Bencher) {
144144
// ── FixedSizeList<i32, 64>: FSL elements ─────────────────────────────────────
145145
#[divan::bench]
146146
fn fsl_rebuild(bencher: Bencher) {
147-
let num_lists = 1_000;
147+
let num_lists = 10;
148148
let list_size = 256;
149149
let fsl_count = num_lists * list_size + list_size;
150150
let inner = PrimitiveArray::from_iter((0..fsl_count * 64).map(|i| i as i32)).into_array();
@@ -166,8 +166,8 @@ fn fsl_rebuild(bencher: Bencher) {
166166
// ── List<i32>: nested list elements ───────────────────────────────────────────
167167
#[divan::bench]
168168
fn list_i32_nested(bencher: Bencher) {
169-
let num_lists = 1_000;
170-
let list_size = 512;
169+
let num_lists = 10;
170+
let list_size = 128;
171171
let elem_count = num_lists * list_size + list_size;
172172
let inner_list_size = 8;
173173
let values = PrimitiveArray::from_iter(0..(elem_count * inner_list_size) as i32).into_array();

‎vortex-array/benches/take_patches.rs‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ const BENCH_ARGS: &[(f64, f64)] = &[
2424
(0.1, 0.5),
2525
(0.1, 0.1),
2626
(0.1, 0.05),
27-
(0.05, 1.0),
28-
(0.05, 0.5),
29-
(0.05, 0.1),
30-
(0.05, 0.05),
3127
(0.01, 1.0),
3228
(0.01, 0.5),
3329
(0.01, 0.1),

0 commit comments

Comments
 (0)