Skip to content

Commit 44780e8

Browse files
committed
style(array): clarify Narrow module boundaries
Signed-off-by: Connor Tsui <[email protected]>
1 parent cc903d4 commit 44780e8

3 files changed

Lines changed: 8 additions & 0 deletions

File tree

‎encodings/fastlanes/tests/narrow.rs‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
// SPDX-License-Identifier: Apache-2.0
22
// SPDX-FileCopyrightText: Copyright the Vortex contributors
33

4+
//! Narrow operations on compressed integer children.
5+
//!
6+
//! BitPacked children retain their stored width through selection and comparison. Canonical
7+
//! execution widens them to Narrow's logical dtype.
8+
49
#![cfg(test)]
510

611
use std::sync::LazyLock;

‎vortex-array/src/arrays/narrow/encoding.rs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ impl NarrowArray {
3232
ptype.is_int(),
3333
"Narrow requires integer values, got {ptype}"
3434
);
35+
3536
if ptype.byte_width() == 1 {
3637
return Ok(array.into_array());
3738
}
@@ -59,6 +60,7 @@ impl NarrowArray {
5960
.as_ref()
6061
.cast(storage_dtype)?
6162
.execute::<PrimitiveArray>(ctx)?;
63+
6264
return Ok(Self::try_new(values.into_array(), array.dtype().clone())?.into_array());
6365
}
6466

‎vortex-array/src/arrays/narrow/mod.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
1111
mod aggregates;
1212
pub(crate) use aggregates::register_aggregate_kernels;
13+
1314
mod compare;
1415
mod encoding;
1516
mod rules;

0 commit comments

Comments
 (0)