Repository navigation
Commit 42bea5d
Add golden-corpus determinism tests for the default compressor (#8697)
Tracking Issue: #8701
Closes: #6171
## Rationale for this change
Groundwork for making the compressor's selection policy pluggable
(#7697): before any refactoring of scheme selection, pin the
compressor's current decisions with reviewable golden snapshots, so each
subsequent PR can demonstrate unchanged selection behavior by showing
zero snapshot churn. Test-only, and lands first so later PRs diff
against a committed baseline.
This also closes #6171 by adding dedicated regression coverage for
whether the compressor produces the expected array tree, across a
representative corpus rather than one-off encoding assertions.
## What changes are included in this PR?
A golden test suite in `vortex-btrblocks`: 20 seed-generated corpus
entries spanning the registered schemes' habitats, each compressed twice
per run (direct determinism check) and snapshotted as its full encoding
tree with exact array-level byte counts. Three feature variants cover
the default scheme pool, `unstable_encodings`, and `with_compact`
(+`zstd`+`pco`).
A dedicated `btrblocks-golden` CI job runs all three feature
combinations explicitly. The variants are mutually exclusive at compile
time (`unstable_encodings` changes `ALL_SCHEMES`), so the existing
`--all-features` workspace test jobs compile the `default` variant out,
and it would otherwise only run incidentally in the default-features
musl job.
OnPair is excluded from the golden compressors: its dictionary training
is nondeterministic run-to-run (randomly-seeded hash maps in the
upstream crate), so it cannot serve as a baseline. That's a pre-existing
bug worth its own issue.
## What APIs are changed? Are there any user-facing changes?
None (tests and CI only).
---------
Signed-off-by: Connor Tsui <[email protected]>
Co-authored-by: Claude <[email protected]>1 parent a530b3b commit 42bea5d
65 files changed
Lines changed: 1170 additions & 0 deletions
File tree
- .github/workflows
- vortex-btrblocks
- tests
- snapshots
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
452 | 452 | | |
453 | 453 | | |
454 | 454 | | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
455 | 487 | | |
456 | 488 | | |
457 | 489 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
0 commit comments