Skip to content

Commit 41b6e8b

Browse files
committed
Shorten the RowFn masking rationale
Signed-off-by: Connor Tsui <[email protected]>
1 parent b756862 commit 41b6e8b

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

  • vortex-array/src/scalar_fn/unstable/row/batch/execute

‎vortex-array/src/scalar_fn/unstable/row/batch/execute/dense.rs‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -112,14 +112,10 @@ impl RowFnExecutionArgs {
112112
self.finalize_output(values, self.row_count)
113113
}
114114
Validity::Array(valid) => {
115-
// `values.mask(valid)` currently reaches encoding-specific masking through
116-
// parent-reduce rules, which need a ScalarFnArray parent to match. Even a successful
117-
// reduction pays for constructing and optimizing that temporary node. Benchmarks
118-
// motivated skipping this setup in RowFn finalization. Doing so inside `.mask()`
119-
// would require direct encoding dispatch or a canonical-specific branch in the
120-
// generic builtin. Keep this micro-optimization local to the internal executor,
121-
// reusing the existing helper instead of changing generic masking dispatch for this
122-
// hot path. Remove this bypass if `.mask()` gains equivalent direct dispatch.
115+
// `values.mask(valid)` builds and optimizes a ScalarFnArray to dispatch through
116+
// parent-reduce rules. Benchmarks motivated bypassing that setup here, keeping the
117+
// exception internal instead of adding canonical-specific dispatch to the generic
118+
// builtin. Remove this bypass if `.mask()` gains equivalent direct dispatch.
123119
// https://github.com/vortex-data/vortex/pull/10742
124120
let values = match values.as_opt::<AnyCanonical>() {
125121
Some(canonical) => mask_validity_canonical(

0 commit comments

Comments
 (0)