Repository navigation
Commit 4030e01
authored
fix: ignore zero-byte benchmark file identities (#9197)
Fixes file-size reporting when either the baseline or HEAD records an
empty file. The report previously dropped the zero-byte row and then
treated its missing counterpart as `0 B`, which could report a false
deletion or a newly created file.
File identities with a zero-byte record on either side are now excluded
from both sides before totals and missing-file comparisons. The
regression test covers both asymmetric cases.
Checks: `uv run --no-project --with orjson --with pandas pytest
scripts/tests/test_benchmark_reporting.py` and `ruff check
scripts/compare-benchmark-jsons.py
scripts/tests/test_benchmark_reporting.py`.
Signed-off-by: Connor Tsui <[email protected]>1 parent 12f7fea commit 4030e01
2 files changed
Lines changed: 42 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
614 | 614 | | |
615 | 615 | | |
616 | 616 | | |
617 | | - | |
618 | | - | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
619 | 621 | | |
620 | 622 | | |
| 623 | + | |
621 | 624 | | |
622 | | - | |
| 625 | + | |
623 | 626 | | |
624 | 627 | | |
625 | 628 | | |
| |||
635 | 638 | | |
636 | 639 | | |
637 | 640 | | |
638 | | - | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
639 | 646 | | |
640 | | - | |
| 647 | + | |
641 | 648 | | |
642 | 649 | | |
643 | 650 | | |
644 | 651 | | |
645 | 652 | | |
646 | | - | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
647 | 657 | | |
648 | 658 | | |
649 | 659 | | |
650 | | - | |
| 660 | + | |
651 | 661 | | |
652 | 662 | | |
653 | 663 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
413 | 413 | | |
414 | 414 | | |
415 | 415 | | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
416 | 441 | | |
417 | 442 | | |
418 | 443 | | |
| |||
0 commit comments