Skip to content

Commit 3a4ded4

Browse files
robert3005claude
authored andcommitted
Shorten the executor's parent-reduce retry comment
Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_018SWbEuVduQbmfuXAPx4p46 Signed-off-by: Robert Kruszewski <[email protected]>
1 parent fddf038 commit 3a4ded4

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

‎vortex-array/src/executor.rs‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -252,13 +252,9 @@ impl ArrayRef {
252252

253253
// Step 1b: parent-reduce rules against the suspended parent.
254254
//
255-
// The optimizer only tried the child's parent-reduce rules with the child it saw
256-
// before execution. Once execution rewrites the child into another encoding, a rule
257-
// can match that did not before: a slice over a run-end array executes into the
258-
// run-end array, whose `RunEndScalarFnRule` pushes the suspended scalar function
259-
// into the run values instead of decoding every row.
260-
//
261-
// Skipped while a builder is active at either level, for the same reason as Step 2a.
255+
// Once execution rewrites the child into another encoding, its parent-reduce rules
256+
// can match where they did not before, such as a slice that executed into a run-end
257+
// array. Skipped while a builder is active at either level, as in Step 2a.
262258
if child_rewritten
263259
&& current_builder.is_none()
264260
&& stack

0 commit comments

Comments
 (0)