Repository navigation
Commit 36cb75d
authored
bench: size the decimal kernel benchmarks by bytes rather than rows (#9980)
## Summary
The decimal kernel benchmarks landed with a 1,024 row case. For `i128`
that runs in 0.4 to 1.2 µs
on the walltime legs, below what those machines resolve, so it reports
mostly jitter: it moved by
10 to 19% on ten of the last thirteen CodSpeed reports, every one of
them on a pull request that
touched no decimal code. No 8,192 row case and no `i256` case has moved
in those reports.
## Changes
Derive each kernel case's row count from a working set of 256 KiB and 1
MiB of input plus output,
rather than fixing it at 1,024 and 8,192 rows:
| Decimal width | Small case | Large case |
| --- | ---: | ---: |
| `i128` | 8,192 rows | 32,768 rows |
| `i256` | 4,096 rows | 16,384 rows |
Both widths now do comparable work, every case takes several
microseconds instead of fractions of
one, and the largest still fits the 1 MiB L2 cache of the Graviton leg,
so these stay measurements
of kernel code rather than of memory bandwidth.
The array benchmarks in the same files are `#[cfg(not(codspeed))]` and
never run in CI, so they
keep their sizes for quick local runs. The benchmarking guide gains the
measured walltime floor
next to the simulation floor documented in #9951.
Expect a one-time batch of CodSpeed rows for these eight cases when this
merges, since the inputs
change size.
Checked with `cargo clippy -p vortex-decimal-byte-parts --all-targets
--all-features -- -D warnings`
and `cargo fmt`. No benchmarks were run locally: this session is a
shared cloud VM, so its walltime
numbers would not mean anything.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01B6ApyxEXpjiasZbQptsypn
---
_Generated by [Claude Code](https://claude.ai/code)_
---------
Signed-off-by: Connor Tsui <[email protected]>1 parent 36b1f86 commit 36cb75d
1 file changed
Lines changed: 16 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
13 | 25 | | |
14 | | - | |
| 26 | + | |
15 | 27 | | |
16 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
17 | 31 | | |
18 | 32 | | |
19 | 33 | | |
| |||
0 commit comments