You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2988965
Browse filesBrowse the repository at this point in the historyBrowse files
Progress towards #9128.
`vortex.tensor.l2_norm`, `vortex.tensor.inner_product`, and
`vortex.tensor.cosine_similarity` become row functions over a
`TensorRow` element, which yields a slice of the extension array's
storage straight to the closure. Lifting supplies the null propagation,
constant folding, nullability, validity, and options serde that the
three kernels each wrote by hand.
Cosine similarity hoists the norm of a broadcast query vector into
`visit_prepared_into`'s prepare step. The prepared and per-row arms must
agree bit for bit, which only holds while both accumulate in the same
order, so `l2_norm_row` moves into `utils.rs` and both call it.
`BinaryTensorOpMetadata` and `build_tensor_array` move there too, shared
by the two binary operators and by the normalized encoding.
Constant folding through `try_build_constant_normalized` is now derived
from the row closure, so the export is gone.
The tests move out of the three kernel modules and into
`scalar_fns/tests/`.
Signed-off-by: Connor Tsui <[email protected]>
Co-authored-by: Claude <[email protected]>
0 commit comments