@@ -179,17 +179,19 @@ impl FromLogicalType for DType {
179179 )
180180 }
181181 DUCKDB_TYPE :: DUCKDB_TYPE_VARIANT => DType :: Variant ( nullability) ,
182- DUCKDB_TYPE :: DUCKDB_TYPE_TIME_TZ => todo ! ( ) ,
183- DUCKDB_TYPE :: DUCKDB_TYPE_INTERVAL => todo ! ( ) ,
184- DUCKDB_TYPE :: DUCKDB_TYPE_ENUM => todo ! ( ) ,
185- DUCKDB_TYPE :: DUCKDB_TYPE_MAP => todo ! ( ) ,
186- DUCKDB_TYPE :: DUCKDB_TYPE_UUID => todo ! ( ) ,
187- DUCKDB_TYPE :: DUCKDB_TYPE_UNION => todo ! ( ) ,
188- DUCKDB_TYPE :: DUCKDB_TYPE_BIT => todo ! ( ) ,
189- DUCKDB_TYPE :: DUCKDB_TYPE_ANY => todo ! ( ) ,
190- DUCKDB_TYPE :: DUCKDB_TYPE_BIGNUM => todo ! ( ) ,
191- DUCKDB_TYPE :: DUCKDB_TYPE_STRING_LITERAL => todo ! ( ) ,
192- DUCKDB_TYPE :: DUCKDB_TYPE_INTEGER_LITERAL => todo ! ( ) ,
182+ other @ ( DUCKDB_TYPE :: DUCKDB_TYPE_TIME_TZ
183+ | DUCKDB_TYPE :: DUCKDB_TYPE_INTERVAL
184+ | DUCKDB_TYPE :: DUCKDB_TYPE_ENUM
185+ | DUCKDB_TYPE :: DUCKDB_TYPE_MAP
186+ | DUCKDB_TYPE :: DUCKDB_TYPE_UUID
187+ | DUCKDB_TYPE :: DUCKDB_TYPE_UNION
188+ | DUCKDB_TYPE :: DUCKDB_TYPE_BIT
189+ | DUCKDB_TYPE :: DUCKDB_TYPE_ANY
190+ | DUCKDB_TYPE :: DUCKDB_TYPE_BIGNUM
191+ | DUCKDB_TYPE :: DUCKDB_TYPE_STRING_LITERAL
192+ | DUCKDB_TYPE :: DUCKDB_TYPE_INTEGER_LITERAL ) => {
193+ vortex_bail ! ( "{other:?} -> DType conversion is not supported" )
194+ }
193195 } )
194196 }
195197}
@@ -241,10 +243,9 @@ impl TryFrom<&DType> for LogicalType {
241243 DType :: Struct ( struct_type, _) => {
242244 return LogicalType :: try_from ( struct_type) ;
243245 }
244- DType :: Union ( ..) => todo ! ( "TODO(connor)[Union]: unimplemented" ) ,
245- DType :: Variant ( _) => {
246- vortex_bail ! ( "Vortex Variant array aren't supported in DuckDB" )
247- }
246+ // TODO(connor): Union
247+ DType :: Union ( ..) => vortex_bail ! ( "Vortex Union isn't supported" ) ,
248+ DType :: Variant ( _) => vortex_bail ! ( "Vortex Variant array aren't supported" ) ,
248249 DType :: Extension ( ext_dtype) => {
249250 // Handle first-party extension types that have DuckDB equivalents.
250251 if let Some ( temporal) = ext_dtype. metadata_opt :: < AnyTemporal > ( ) {
0 commit comments