Skip to content

Commit 1d09649

Browse files
authored
Run each CodSpeed job on one instance type (#10965)
Signed-off-by: Robert Kruszewski <[email protected]>
1 parent 6cc1b92 commit 1d09649

1 file changed

Lines changed: 13 additions & 15 deletions

File tree

‎.github/workflows/codspeed.yml‎

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,10 @@ jobs:
6262
- { shard: 9, name: "Strings, tensor & spatial", packages: "vortex-fsst vortex-tensor vortex-spatial", features: "--features _test-harness" }
6363
name: "Benchmark with Codspeed (Shard #${{ matrix.shard }} - ${{ matrix.name }})"
6464
timeout-minutes: 30
65+
# Each CodSpeed runner is pinned to one instance type, because results depend on the CPU.
6566
runs-on: >-
6667
${{ github.repository == 'vortex-data/vortex'
67-
&& format('runs-on={0}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/extras=s3-cache/tag=bench-codspeed-{1}', github.run_id, matrix.shard)
68+
&& format('runs-on={0}/runner=amd64-codspeed-simulation/tag=bench-codspeed-{1}', github.run_id, matrix.shard)
6869
|| 'ubuntu-latest' }}
6970
steps:
7071
- uses: runs-on/action@v2
@@ -150,7 +151,7 @@ jobs:
150151
timeout-minutes: 45
151152
runs-on: >-
152153
${{ github.repository == 'vortex-data/vortex'
153-
&& format('runs-on={0}/runner=amd64-medium/image=ubuntu24-full-x64-pre-v2/extras=s3-cache/tag=bench-codspeed-python', github.run_id)
154+
&& format('runs-on={0}/runner=amd64-codspeed-simulation/tag=bench-codspeed-python', github.run_id)
154155
|| 'ubuntu-latest' }}
155156
env:
156157
# Same settings as the bench profile, which keeps the debug info that CodSpeed uses to
@@ -203,32 +204,29 @@ jobs:
203204
# the build flags, not the silicon. c7i.metal-24xl is the smaller of the two c7i
204205
# metal sizes: Sapphire Rapids, and AVX-512 capable.
205206
- features: avx2
206-
family: c7i.metal-24xl
207-
build-family: c7i.4xlarge
208-
image: ubuntu24-full-x64-pre-v2
207+
runner: amd64-codspeed-walltime
208+
build-runner: amd64-codspeed-build
209209
rustflags: "-C target-feature=+avx2 -C force-frame-pointers=yes"
210210
# Every AVX-512 extension Sapphire Rapids implements, not just the two the current
211211
# `cfg(target_feature)` gates test for. Those gates decide which kernel the code
212212
# under test selects, but the rest of the build — anything the compiler
213213
# auto-vectorizes, the scalar baselines included — sees the whole feature set, and
214214
# a two-feature build is not what anything ships on.
215215
- features: avx512
216-
family: c7i.metal-24xl
217-
build-family: c7i.4xlarge
218-
image: ubuntu24-full-x64-pre-v2
216+
runner: amd64-codspeed-walltime
217+
build-runner: amd64-codspeed-build
219218
rustflags: >-
220219
-C target-feature=+avx512f,+avx512bw,+avx512cd,+avx512dq,+avx512vl,+avx512ifma,+avx512vbmi,+avx512vbmi2,+avx512vnni,+avx512bitalg,+avx512vpopcntdq,+avx512bf16,+avx512fp16
221220
-C force-frame-pointers=yes
222221
# Graviton3 supports SVE, so this family can also host a future SVE leg.
223222
- features: neon
224-
family: c7g.metal
225-
build-family: c7g.4xlarge
226-
image: ubuntu24-full-arm64-pre-v2
223+
runner: arm64-codspeed-walltime
224+
build-runner: arm64-codspeed-build
227225
rustflags: "-C target-feature=+neon -C force-frame-pointers=yes"
228226
name: "Build Codspeed CPU benchmarks (${{ matrix.features }})"
229227
timeout-minutes: 30
230228
runs-on: >-
231-
runs-on=${{ github.run_id }}/runner=bench-dedicated/family=${{ matrix.build-family }}/image=${{ matrix.image }}/extras=s3-cache/tag=bench-codspeed-cpu-features-build-${{ matrix.features }}
229+
runs-on=${{ github.run_id }}/runner=${{ matrix.build-runner }}/tag=bench-codspeed-cpu-features-build-${{ matrix.features }}
232230
steps:
233231
- uses: runs-on/action@v2
234232
with:
@@ -297,7 +295,7 @@ jobs:
297295
name: "Benchmark with Codspeed (${{ matrix.features }})"
298296
timeout-minutes: 30
299297
runs-on: >-
300-
runs-on=${{ github.run_id }}/runner=bench-dedicated/family=${{ matrix.family }}/image=${{ matrix.image }}/extras=s3-cache/tag=bench-codspeed-cpu-features-${{ matrix.features }}
298+
runs-on=${{ github.run_id }}/runner=${{ matrix.runner }}/tag=bench-codspeed-cpu-features-${{ matrix.features }}
301299
steps:
302300
# Initialise the RunsOn artifact proxy used by download-artifact.
303301
- uses: runs-on/action@v2
@@ -350,7 +348,7 @@ jobs:
350348
name: "Build Codspeed CUDA benchmarks"
351349
timeout-minutes: 30
352350
runs-on: >-
353-
runs-on=${{ github.run_id }}/family=g5/cpu=8/image=ubuntu24-gpu-x64/extras=s3-cache/tag=bench-codspeed-cuda-build
351+
runs-on=${{ github.run_id }}/runner=gpu-codspeed/tag=bench-codspeed-cuda-build
354352
steps:
355353
- uses: runs-on/action@v2
356354
with:
@@ -411,7 +409,7 @@ jobs:
411409
name: "Benchmark with Codspeed (CUDA Shard #${{ matrix.shard }} - ${{ matrix.name }})"
412410
timeout-minutes: 30
413411
runs-on: >-
414-
runs-on=${{ github.run_id }}/family=g5/cpu=8/image=ubuntu24-gpu-x64/extras=s3-cache/tag=bench-codspeed-cuda-${{ matrix.shard }}
412+
runs-on=${{ github.run_id }}/runner=gpu-codspeed/tag=bench-codspeed-cuda-${{ matrix.shard }}
415413
steps:
416414
- uses: runs-on/action@v2
417415
with:

0 commit comments

Comments
 (0)