You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 1b34a5e
Browse filesBrowse the repository at this point in the historyBrowse files
Makes `Root` an `Expression` variant instead of a `ScalarFnVTable`
implementation.
This is groundwork for lambdas and variables — those are also nodes
whose dtype comes from the
scope rather than from their children, and they need the same treatment.
`Root` is not a scalar function. Its dtype comes from the scope rather
than from its children (it has no children) and it is not executable.
This PR makes `Expression` an enum instead of a struct. `Root` becomes a
variant, and upcoming `Lambda` and `Variable` become variants as well.
```rust
pub enum Expression {
Scalar { scalar_fn: ScalarFnRef, children: Arc<Vec<Expression>> },
Root,
}
```
This is a small breaking change.
---------
Signed-off-by: Matt Katz <[email protected]>
0 commit comments