Skip to content

Commit 18ed8d1

Browse files
Merge branch 'develop' into cwirt/spark-nullable-inferred-schema
2 parents 117fee5 + 5d84290 commit 18ed8d1

23 files changed

Lines changed: 645 additions & 248 deletions

File tree

‎.github/workflows/develop-bench.yml‎

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -12,25 +12,6 @@ permissions:
1212
contents: write
1313

1414
jobs:
15-
commit-metadata:
16-
runs-on: ubuntu-latest
17-
timeout-minutes: 10
18-
steps:
19-
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
20-
- name: Setup AWS CLI
21-
uses: aws-actions/configure-aws-credentials@e1253824e5c10ff9df46874f81ed3ec929e19cfd # v6
22-
with:
23-
role-to-assume: arn:aws:iam::245040174862:role/GitHubBenchmarkRole
24-
aws-region: us-east-1
25-
- name: Upload Commit Metadata
26-
shell: bash
27-
run: |
28-
set -Eeu -o pipefail -x
29-
30-
sudo apt-get update && sudo apt-get install -y jq
31-
bash scripts/commit-json.sh > new-commit.json
32-
bash scripts/cat-s3.sh vortex-ci-benchmark-results commits.json new-commit.json
33-
3415
build:
3516
timeout-minutes: 60
3617
runs-on: >-
@@ -217,15 +198,10 @@ jobs:
217198
run: |
218199
python3 scripts/string-split.py
219200
220-
- name: Upload Benchmark Results
221-
shell: bash
222-
run: |
223-
bash scripts/cat-s3.sh vortex-ci-benchmark-results data.json.gz results.json
224-
225201
# v4 (Postgres) ingest -- the REQUIRED benchmark-results pipeline feeding the live
226202
# benchmarks website for suites that emit v4 records; a failure here fails the job.
227-
# All suites also upload S3 results above. string-bench does not emit
228-
# results.ingest.jsonl, so these steps are disabled for it.
203+
# string-bench does not emit results.ingest.jsonl, so these steps are disabled for it
204+
# and its results are not stored.
229205
# Also gated on the ingest-role ARN var (the assume-role input that MUST exist for
230206
# OIDC to succeed). post-ingest.py mints the RDS IAM token internally (boto3) from
231207
# the assumed GitHubBenchmarkIngestRole; sslmode=verify-full validates the cert.

‎.github/workflows/sql-bench-matrix.yml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -282,12 +282,6 @@ jobs:
282282
Benchmark `${{ matrix.name }}` (${{ inputs.matrix_preset }}) failed! Check the [workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}) for details.
283283
comment-tag: bench-pr-comment-${{ matrix.id }}-${{ inputs.matrix_preset }}
284284

285-
- name: Upload Benchmark Results
286-
if: inputs.mode == 'develop'
287-
shell: bash
288-
run: |
289-
bash scripts/cat-s3.sh vortex-ci-benchmark-results data.json.gz results.json
290-
291285
# v4 (Postgres) ingest -- the REQUIRED benchmark-results pipeline feeding the live
292286
# benchmarks website (see develop-bench.yml for the full rationale); a failure here fails the
293287
# job. Gated on inputs.mode == 'develop' + the ingest-role ARN var (the assume-role

0 commit comments

Comments
 (0)