Repository navigation
Commit 036e9a2
committed
Compare primitive values through the shared RowFn executor
PrimitiveCompare only selects the predicate for each primitive type and operator. The RowFn executor handles decoding, batch constants, validity, and packed Boolean output, so the private lane kernel packing path and PrimitiveOperand are removed. CompareArgs borrows both operands and builds their primitive dtypes, so a call does not allocate.
The public Binary identity and the floating-point total ordering are unchanged. A constant on either side gets the same full-width loop in the rustc 1.99.1 LLVM IR for x86 AVX-512 and aarch64, so the comparison does not move a constant left operand to the right.
Signed-off-by: Connor Tsui <[email protected]>1 parent 518ee6e commit 036e9a2
12 files changed
Lines changed: 152 additions & 295 deletions
File tree
- vortex-array
- benches
- src/scalar_fn
- fns/binary
- compare
- unstable/row
- batch
- execute
- execute
- types/element/tuple
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
12 | 9 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
17 | 13 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
22 | 18 | | |
23 | 19 | | |
24 | 20 | | |
| |||
66 | 62 | | |
67 | 63 | | |
68 | 64 | | |
69 | | - | |
| 65 | + | |
70 | 66 | | |
71 | 67 | | |
72 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| 18 | + | |
| 19 | + | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
| |||
209 | 212 | | |
210 | 213 | | |
211 | 214 | | |
212 | | - | |
| 215 | + | |
213 | 216 | | |
214 | 217 | | |
215 | 218 | | |
| |||
0 commit comments