Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

append /fd flag unconditionally. #152

Merged
merged 2 commits into from
Jan 19, 2022
Merged

append /fd flag unconditionally. #152

merged 2 commits into from
Jan 19, 2022

Conversation

cstkingkey
Copy link
Contributor

fix issue #149

@volks73
Copy link
Owner

volks73 commented Jan 19, 2022 •
edited
Loading

@cstkingkey Thanks for the PR! It looks good, but can you run rustfmt to address the CI fail, please?

It might be good to eventually add a command line argument for the cargo wix sign sub-command to change the certification hash. I will create an issue/feature request for this, but it does not need to be completed to merge this PR.

@volks73 volks73 added the bug label Jan 19, 2022
@volks73 volks73 linked an issue Jan 19, 2022 that may be closed by this pull request
signtool complain about missing /fd flag #149
Closed
@volks73 volks73 merged commit 8e497a4 into volks73:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cstkingkey cstkingkey

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

signtool complain about missing /fd flag
2 participants
@cstkingkey @volks73