Fix config handling, provide poll interval#78
Conversation
static/js/vole.js
Outdated
There was a problem hiding this comment.
Is this a race condition? How can we be sure the config has been fetched before we reference it in setTimeout?
There was a problem hiding this comment.
The first poll is hardcoded to happen after 5s, so the config will be available. However I can put a check in to make sure it's not undefined.
There was a problem hiding this comment.
Cool. A check is good for now. Another thought is to serve the config as part of the HTML so we can be certain it's available without having to make an ajax call.
|
This looks good to me (aside from the one comment). I like getting rid of the sample config file. |
|
@ilario Are you sure you're running the latest code? The backend doesn't read config.sample.json anymore. It has the default values compiled in. It will attempt to read config.json if it exists, and any value in there will override the default. |
Fix config handling, provide poll interval
|
You were right, I'm sorry, it was my fault (I was using old code due to a mistake in my launcher). |
|
Great, glad it's working for you. |
3 participants
Fixes #75