Skip to content

Remove default max-width from images#65

Merged
marktheunissen merged 4 commits intovole:masterfrom
rupl:bigger-images
Jun 28, 2013
Merged

Remove default max-width from images#65
marktheunissen merged 4 commits intovole:masterfrom
rupl:bigger-images

Conversation

@rupl
Copy link
Copy Markdown
Contributor

@rupl rupl commented Jun 27, 2013

This just overrides one tiny setting in Bootstrap, and the result is images can be wide than the post width:

screen shot 2013-06-26 at 9 43 27 pm

@rupl
Copy link
Copy Markdown
Contributor Author

rupl commented Jun 27, 2013

Actually there is a point where it's too much. Here's the max:

screen shot 2013-06-26 at 9 51 31 pm

@marktheunissen
Copy link
Copy Markdown
Member

I think I like it more when it's constrained to the width of the column. Perhaps there's another way to show a larger picture without clicking on the link. Like some kind of very fast Lightbox or zoom type feature

@marktheunissen
Copy link
Copy Markdown
Member

Hmm, actually it's pretty cool. @pifantastic what do you think?

What we really need is an actual design #36

@marktheunissen
Copy link
Copy Markdown
Member

Yeah this is a +1 from me now that I have grown accustomed to it. I shouldn't be making design decisions anyway. o_O

@rupl
Copy link
Copy Markdown
Contributor Author

rupl commented Jun 27, 2013

Like some kind of very fast Lightbox or zoom type feature

done

@marktheunissen
Copy link
Copy Markdown
Member

👍 Thanks this works great.

marktheunissen added a commit that referenced this pull request Jun 28, 2013
Remove default max-width from images
@marktheunissen marktheunissen merged commit 9fe34c5 into vole:master Jun 28, 2013
@pifantastic
Copy link
Copy Markdown
Member

Ha! That's smooth. Thanks @rupl.

@rupl rupl deleted the bigger-images branch June 28, 2013 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants