Skip to content

fix(openclaw-plugin): sanitize mapped session IDs for Windows#998

Merged
Mijamind719 merged 1 commit intomainfrom
fix/openclaw-plugin-safe-session-id
Mar 26, 2026
Merged

fix(openclaw-plugin): sanitize mapped session IDs for Windows#998
Mijamind719 merged 1 commit intomainfrom
fix/openclaw-plugin-safe-session-id

Conversation

@qin-ctx
Copy link
Copy Markdown
Collaborator

@qin-ctx qin-ctx commented Mar 26, 2026

Description

Fix the OpenClaw OpenViking plugin's session mapping so OpenClaw session keys containing Windows-invalid characters no longer become raw OpenViking session IDs.

Related Issue

Fixes #999

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • Map unsafe OpenClaw sessionKey values to stable filesystem-safe OpenViking session IDs
  • Use the mapped session ID consistently for auto-capture, commit, delete, and explicit session resolution
  • Update plugin text to describe the stable mapped-session behavior instead of a raw 1:1 mapping

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

N/A

Additional Notes

  • Verified locally with npm test in examples/openclaw-plugin.
  • Git commit was created with --no-verify because the local git hook environment is missing the pre_commit Python module.

Map OpenClaw session keys to stable filesystem-safe OpenViking session ids so auto-capture and memory commits work on Windows.
@github-actions
Copy link
Copy Markdown

Failed to generate code suggestions for PR

@Mijamind719 Mijamind719 merged commit 7b2b910 into main Mar 26, 2026
7 checks passed
@Mijamind719 Mijamind719 deleted the fix/openclaw-plugin-safe-session-id branch March 26, 2026 09:00
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Mar 26, 2026
zeattacker pushed a commit to zeattacker/OpenViking that referenced this pull request Mar 27, 2026
…ine#998)

Map OpenClaw session keys to stable filesystem-safe OpenViking session ids so auto-capture and memory commits work on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

bug(openclaw-plugin): Windows fails when sessionKey contains path-invalid characters

2 participants