Skip to content

fix(ov-cli): preserve .zip suffix for temp archives uploaded from directories#1021

Merged
MaojiaSheng merged 2 commits intovolcengine:mainfrom
Shawn-cf-o:fix/ov-cli-temp-zip-suffix
Mar 27, 2026
Merged

fix(ov-cli): preserve .zip suffix for temp archives uploaded from directories#1021
MaojiaSheng merged 2 commits intovolcengine:mainfrom
Shawn-cf-o:fix/ov-cli-temp-zip-suffix

Conversation

@Shawn-cf-o
Copy link
Copy Markdown
Contributor

Summary

  • add a .zip suffix when ov_cli creates temporary archives for directory uploads
  • align Rust CLI behavior with openviking_cli/client/http.py, which already uploads directory archives with a .zip filename
  • prevent server-side extraction failures when uploads routed through /api/v1/resources/temp_upload are stored without a recognizable archive suffix

Test plan

  • run ov add-resource <local-directory> from the Rust CLI and confirm the directory upload is accepted
  • verify the temporary archive created by ov_cli ends with .zip
  • confirm the uploaded temp artifact can be recognized and extracted by the server

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 27, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown

Failed to generate code suggestions for PR

@MaojiaSheng MaojiaSheng merged commit 8082830 into volcengine:main Mar 27, 2026
2 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Mar 27, 2026
@Shawn-cf-o Shawn-cf-o deleted the fix/ov-cli-temp-zip-suffix branch March 27, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants