Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Failed to generate code suggestions for PR

Thanks for your commit!

1) [P1] Interactive card missing config/header may break message sending

File: bot/vikingbot/channels/feishu.py

Location (new): L574-L575

Relevant code:

card_content = json.dumps({"elements": card_elements}, ensure_ascii=False)

Issue:

The interactive card content currently contains only the elements field and is missing config/header. This differs from the official examples; if the server performs strict card schema validation, it can cause message creation to fail. Also, without wide_screen_mode, long text/tables are more likely to be truncated.

Suggestion:

Add config (and header if needed) while keeping elements unchanged, and explicitly enable wide screen mode.

Drop-in example code:

card_payload = {
    "config": {"wide_screen_mode": True},
    "elements": card_elements,
}
card_content = json.dumps(card_payload, ensure_ascii=False)

2) [P1] img element in interactive card misses alt

File: bot/vikingbot/channels/feishu.py

Location (new): L567-L570

Relevant code:

card_elements.append({"tag": "img", "img_key": img["image_key"]})

Issue:

In official card examples, an img component typically includes an alt field (plain_text). The current payload only sends {tag: 'img', img_key: ...}; under stricter validation, this can be considered an incomplete structure and fail to send.

Suggestion:

Add alt (it can be an empty string) to align with the standard card schema.

Drop-in example code:

for img in images:
    card_elements.append(
        {
            "tag": "img",
            "img_key": img["image_key"],
            "alt": {"tag": "plain_text", "content": ""},
        }
    )

3) [P2] Quote the id value in the @mention tag

File: bot/vikingbot/channels/feishu.py

Location (new): L553-L556

Relevant code:

mention_prefix = f"<at id={original_sender_id}></at>"

Issue:

The mention prefix is built as f"<at id={original_sender_id}></at>" and the id value is not quoted. Some rendering paths are stricter and may fail to parse it correctly, causing the mention to not render or not trigger a notification.

Suggestion:

Wrap the id value in double quotes to reduce parsing ambiguity.

Drop-in example code:

mention_prefix = f'<at id="{original_sender_id}"></at>'