Update: Populate hyperNode info #3964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: penggu <[email protected]>
volcano-sh-bot
added
kind/feature
volcano-sh-bot
requested review from
hzxuzhonghu,
shinytang6 and
wangyang0616
volcano-sh-bot
added
the
size/XXL
Monokaix
force-pushed
the
network-informer-1
branch
7 times, most recently
from
3b46ea5 to
fd774ab
Compare
Member
Author
hwdef
reviewed
Jan 13, 2025
| "k8s.io/klog/v2" | ||
|
|
||
| schedulingv1beta1 "volcano.sh/apis/pkg/apis/scheduling/v1beta1" | ||
|
|
Member
|
Some minor issues. |
Signed-off-by: Monokaix <[email protected]>
Monokaix
force-pushed
the
network-informer-1
branch
from
fd774ab to
4d3d6ee
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hwdef The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Member
|
/ok-to-test |
volcano-sh-bot
added
the
ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area scheduling
What this PR does / why we need it:
Which issue(s) this PR fixes:
Related issue: #3881
Fixes #
Special notes for your reviewer:
This is based on #3922 and do some clean up and add ut.
Does this PR introduce a user-facing change?