Network topo admission validate hypernode #3897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/L
weapons97
force-pushed
the
network-topo-admission-validate-hypernode
branch
3 times, most recently
from
c54f1b8 to
8f8a935
Compare
| } | ||
|
|
||
| // validateHyperNodeName is to validate hypernode name. | ||
| func validateHyperNodeName(value string, fldPath *field.Path) field.ErrorList { |
Member
There was a problem hiding this comment.
There is no need to add this func, kube-apiserver already has validation func to validate the crd resource name
weapons97
force-pushed
the
network-topo-admission-validate-hypernode
branch
3 times, most recently
from
b54065a to
cccc032
Compare
volcano-sh-bot
added
the
needs-rebase
weapons97
force-pushed
the
network-topo-admission-validate-hypernode
branch
from
cccc032 to
decacbf
Compare
volcano-sh-bot
removed
the
needs-rebase
Signed-off-by: weipeng <[email protected]>
weapons97
force-pushed
the
network-topo-admission-validate-hypernode
branch
from
decacbf to
8a09bd6
Compare
Member
|
Great! |
Member
hwdef
reviewed
Jan 15, 2025
| } | ||
|
|
||
| // validateHyperNode is to validate hypernode. | ||
| func validateHyperNode(hypernode *hypernodev1alpha1.HyperNode) error { |
Contributor
Author
There was a problem hiding this comment.
it used by line 76 in AdmitHyperNode functions, and hypernode must not nil because schema.DecodeHyperNode will return error when res has error
hwdef
reviewed
Jan 15, 2025
| errs := field.ErrorList{} | ||
| resourcePath := field.NewPath("") | ||
|
|
||
| for _, member := range hypernode.Spec.Members { |
Member
There was a problem hiding this comment.
Will len(hypernode.Spec.Members) will be 0?
Contributor
Author
There was a problem hiding this comment.
thanks, i changed
Monokaix
reviewed
Jan 15, 2025
weapons97
force-pushed
the
network-topo-admission-validate-hypernode
branch
from
86aad15 to
51bbe9d
Compare
Member
|
/ok-to-test |
volcano-sh-bot
added
the
ok-to-test
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
weapons97
force-pushed
the
network-topo-admission-validate-hypernode
branch
from
51bbe9d to
7c25611
Compare
Signed-off-by: weapons97 <[email protected]>
weapons97
force-pushed
the
network-topo-admission-validate-hypernode
branch
from
7c25611 to
296c650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realted to: #3878
Add admission validate for hypernode