Fix device share plugins npe & update devicescore #3471
Conversation
volcano-sh-bot
added
the
size/L
| @@ -0,0 +1,134 @@ | |||
| /* | |||
| Copyright 2019 The Volcano Authors. | |||
| addResource(p1.Spec.Containers[0].Resources.Requests, gpunumber, "1") | ||
| addResource(p1.Spec.Containers[0].Resources.Requests, gpumemory, "1000") | ||
| p1.Spec.Containers[0].Resources.Limits = make(v1.ResourceList) | ||
| addResource(p1.Spec.Containers[0].Resources.Limits, gpunumber, "1") |
There was a problem hiding this comment.
BuildResourceList can directly add scaler resource.
There was a problem hiding this comment.
BuildResourceList doesn't add scalar resources to .containers.resources.limits, so we have to do it here manually
| a higher score than those needs to evict a task */ | ||
|
|
||
| // Use cached stored in filter state in order to avoid recalculating. | ||
| klog.V(3).Infof("Scoring pod %s with to node %s with score %f", pod.Name, gs.Name, gs.Score) |
There was a problem hiding this comment.
ssn.AddNodeOrderFn has already print the score with log level 5, it's not necessary to print here cause it will print logs of logs.
| Memory: uint(devmem), | ||
| Type: items[3], | ||
| Health: health, | ||
| if len(val) > 0 { |
Signed-off-by: limengxuan <[email protected]>
1.Fix device share plugins npe 2.Fix vgpu device handshake patch error 3.update and add deviceshare ut
archlitchi
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
4 participants
Merge PR 3351: Fix NPU exception #3351
Fix NPU on metrics, leading to scheduler crash when running on none-nvidia type gpu node
Merge PR 3210: Add Score to devices
Add the entrance for volcano-vgpu new location in device-share.md