fix errTask channel memory leak #3434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/M
bibibox
force-pushed
the
release-1.9-dev
branch
from
dc1310a to
73ccfed
Compare
Signed-off-by: Wenbo Zhang <[email protected]>
bibibox
force-pushed
the
release-1.9-dev
branch
from
73ccfed to
3da501f
Compare
Monokaix
reviewed
Apr 23, 2024
pkg/scheduler/cache/cache.go
Outdated
| sc.resyncTask(task) | ||
| reSynced = true | ||
| } else { | ||
| klog.V(4).Infof("sync task <%s/%s> success", task.Namespace, task.Name) |
Monokaix
reviewed
Apr 23, 2024
| reSynced = true | ||
| } else { | ||
| klog.V(4).Infof("sync task <%s/%s> success", task.Namespace, task.Name) | ||
| sc.errTasks.Forget(obj) |
Member
There was a problem hiding this comment.
If CustomBindErrHandler execute successfully, we should also forget it.
Contributor
Author
There was a problem hiding this comment.
We have forgot it when sync task successfully, just need resync task when CustomBindErrHandler execute failed
Monokaix
reviewed
Apr 23, 2024
| } else { | ||
| jobErr = fmt.Errorf("failed to find Job <%v> for Task %v/%v", | ||
| pi.Job, pi.Namespace, pi.Name) | ||
| klog.Warningf("failed to find job <%v> for Task <%v/%v>", pi.Job, pi.Namespace, pi.Name) |
| taskKey, ok := obj.(string) | ||
| if !ok { | ||
| klog.Errorf("failed to convert %v to *schedulingapi.TaskInfo", obj) | ||
| klog.Errorf("Failed to convert %v to string.", obj) |
Member
There was a problem hiding this comment.
The obj format is incorrect. Is it more reasonable to exclude Forget?
Member
|
Should also merge to master. |
Signed-off-by: Wenbo Zhang <[email protected]>
bibibox
force-pushed
the
release-1.9-dev
branch
from
e5decd5 to
1693cb0
Compare
Member
|
/lgtm |
william-wang
approved these changes
Apr 25, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current errTask has some problems as follows:
this PR fix these problems