Skip to content

Conversation

@bibibox
Copy link
Contributor

@bibibox bibibox commented Feb 23, 2024

Related issue: #3012

This PR add a feature gate for pdb resource.

@volcano-sh-bot
Copy link
Contributor

Welcome @bibibox!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 23, 2024
@Monokaix
Copy link
Member

Please add some backgroud info and sign off your commit.

@bibibox bibibox force-pushed the add_pdb_feature_gate branch 2 times, most recently from 1dbd290 to 0aa5307 Compare February 23, 2024 06:38
@bibibox bibibox changed the title add pdb support feature gate Add pdb support feature gate Feb 23, 2024
@bibibox
Copy link
Contributor Author

bibibox commented Feb 23, 2024

Please add some backgroud info and sign off your commit.

done

@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2024
@william-wang
Copy link
Member

@bibibox please update the licenses lint.

@bibibox bibibox force-pushed the add_pdb_feature_gate branch from 0aa5307 to 45dd748 Compare February 25, 2024 07:53
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2024
@bibibox bibibox force-pushed the add_pdb_feature_gate branch from 45dd748 to ba809bf Compare February 26, 2024 01:55
Signed-off-by: Wenbo Zhang <[email protected]>
@bibibox bibibox force-pushed the add_pdb_feature_gate branch from ba809bf to 6127f20 Compare February 26, 2024 02:12
@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@volcano-sh-bot volcano-sh-bot merged commit 94c62a4 into volcano-sh:master Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants