Skip to content

Conversation

@hezhangjian
Copy link
Member

@hezhangjian hezhangjian commented Feb 22, 2023

See #2679 for details.
This PR mainly adds the capability to fetch Elasticsearch metrics to Volcano, enabling it to integrate with a wider range of monitoring systems.

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 22, 2023
@gj409237405
Copy link
Contributor

Reviewed

@hezhangjian hezhangjian force-pushed the volcano-metrics-source branch 3 times, most recently from 1d990a8 to 81b698c Compare February 22, 2023 13:59
@hezhangjian hezhangjian force-pushed the volcano-metrics-source branch from 81b698c to 4fdf5f5 Compare February 22, 2023 14:08
@jiangkaihua
Copy link
Contributor

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2023
@volcano-sh-bot volcano-sh-bot merged commit ec564bc into volcano-sh:master Feb 23, 2023
@hezhangjian hezhangjian deleted the volcano-metrics-source branch February 23, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants