Skip to content

Rename AddPrePredicateFn annotation #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
volcano-sh-bot merged 2 commits into from
Feb 27, 2023
Merged

Rename AddPrePredicateFn annotation #2689

volcano-sh-bot merged 2 commits into from
Feb 27, 2023

Conversation

@zbbkeepgoing
Copy link
Contributor

@zbbkeepgoing zbbkeepgoing commented Feb 20, 2023

No description provided.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2023
@zbbkeepgoing
Copy link
Contributor Author

zbbkeepgoing commented Feb 20, 2023 •
edited
Loading

/retest

@zbbkeepgoing
Copy link
Contributor Author

zbbkeepgoing commented Feb 20, 2023

/assign @Thor-wl

@zbbkeepgoing
Copy link
Contributor Author

zbbkeepgoing commented Feb 20, 2023

/unassign @k82cn @merryzhou

hwdef
hwdef reviewed Feb 20, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
william-wang
william-wang approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot
Copy link
Contributor

volcano-sh-bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl, william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zbbkeepgoing
Copy link
Contributor Author

zbbkeepgoing commented Feb 23, 2023

/retest

@volcano-sh-bot
Copy link
Contributor

volcano-sh-bot commented Feb 23, 2023

@zbbkeepgoing: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zbbkeepgoing
Copy link
Contributor Author

zbbkeepgoing commented Feb 24, 2023

/retest

@volcano-sh-bot
Copy link
Contributor

volcano-sh-bot commented Feb 24, 2023

@zbbkeepgoing: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2023
@zbbkeepgoing
Copy link
Contributor Author

zbbkeepgoing commented Feb 24, 2023

@hwdef @Thor-wl Lgtm label removed due to rerunning CI, please help to relabel.

hwdef
hwdef reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@volcano-sh-bot volcano-sh-bot merged commit 3bb09c2 into volcano-sh:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@william-wang william-wang william-wang approved these changes

@k82cn k82cn Awaiting requested review from k82cn

@merryzhou merryzhou Awaiting requested review from merryzhou

+2 more reviewers

@hwdef hwdef hwdef left review comments

@Thor-wl Thor-wl Thor-wl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@william-wang william-wang

@hwdef hwdef

@Thor-wl Thor-wl

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zbbkeepgoing @volcano-sh-bot @william-wang @hwdef @Thor-wl