Skip to content

delete task qos limit in webhook #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
volcano-sh-bot merged 1 commit into from
Sep 28, 2022
Merged

delete task qos limit in webhook #2513

volcano-sh-bot merged 1 commit into from
Sep 28, 2022

Conversation

@waiterQ
Copy link
Contributor

@waiterQ waiterQ commented Sep 28, 2022

for #2511

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 28, 2022
@waiterQ waiterQ force-pushed the del-qos-limit branch 2 times, most recently from d489d2b to 9bdab66 Compare September 28, 2022 06:28
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2022
william-wang
william-wang approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@volcano-sh-bot
Copy link
Contributor

volcano-sh-bot commented Sep 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@volcano-sh-bot volcano-sh-bot merged commit c1537d5 into volcano-sh:master Sep 28, 2022
@waiterQ waiterQ deleted the del-qos-limit branch September 30, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@william-wang william-wang william-wang approved these changes

@wpeng102 wpeng102 Awaiting requested review from wpeng102

Assignees

@william-wang william-wang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@waiterQ @volcano-sh-bot @william-wang