Add selector spread plugin #2500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/M
volcano-sh-bot
added
the
do-not-merge/work-in-progress
elinx
force-pushed
the
selector-spread
branch
2 times, most recently
from
1cdb5f8 to
980e308
Compare
| args.GetInt(&weight.imageLocalityWeight, ImageLocalityWeight) | ||
|
|
||
| // Checks whether selectorspread.weight is provided or not, if given, modifies the value in weight struct. | ||
| args.GetInt(&weight.selectorSpreadWeight, ImageLocalityWeight) |
Member
There was a problem hiding this comment.
why use ImageLocalityWeight in args.GetInt(&weight.selectorSpreadWeight, ImageLocalityWeight)
elinx
force-pushed
the
selector-spread
branch
3 times, most recently
from
df3c5ec to
fc25fdc
Compare
volcano-sh-bot
removed
the
do-not-merge/work-in-progress
elinx
force-pushed
the
selector-spread
branch
2 times, most recently
from
0829bf6 to
d63ad50
Compare
volcano-sh-bot
added
size/L
elinx
force-pushed
the
selector-spread
branch
8 times, most recently
from
54539a7 to
44e7645
Compare
elinx
force-pushed
the
selector-spread
branch
from
44e7645 to
89d17bc
Compare
pkg/scheduler/cache/cache.go
Outdated
| }) | ||
| // explictly register informers to the factory, otherwise resources listers cannot get anything | ||
| // even with no erorr returned. | ||
| informerFactory.Core().V1().Namespaces().Informer() |
Member
There was a problem hiding this comment.
Only selectorSpread plugin and topology spread plugin need below informer register?
Author
There was a problem hiding this comment.
The InterPodAffinity plugin need the namespace informer, SelectorSpread and PodTopologySpread needs the following four.
Member
|
@elinx please merge the two commits to one. |
elinx
force-pushed
the
selector-spread
branch
from
89d17bc to
06dbc64
Compare
- fix plugin use listers listing resource failed Signed-off-by: xilinxing <[email protected]>
elinx
force-pushed
the
selector-spread
branch
from
06dbc64 to
9dc9914
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
5 tasks
waiterQ
pushed a commit
to waiterQ/volcano
that referenced
this pull request
Oct 19, 2022
…add podTopologySpread plugin) conflict; Signed-off-by: shaoqiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix #2503