Skip to content

Conversation

@jiangkaihua
Copy link
Contributor

run find ./ -name "*.go" | xargs gofmt -w in volcano.sh/volcano path to modify format verification.

Signed-off-by: jiangkaihua [email protected]

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 21, 2022
@hzxuzhonghu
Copy link
Member

IMo go format should be verified in with ci, curious doesn't volcano has that?

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@hzxuzhonghu
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot merged commit 630e6e5 into volcano-sh:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants