Fix calculating available gpu num error #2441
Conversation
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
volcano-sh-bot
added
the
size/S
| } | ||
|
|
||
| return nil | ||
| return allocatableGPUs[:gpuRequest] |
There was a problem hiding this comment.
Another concern here is should we always return the idle gpus, what about including the allocable gpus.
There was a problem hiding this comment.
@Thor-wl Does this make sense? Actually I haven't seen the original design.
Signed-off-by: kerthcet <[email protected]>
volcano-sh-bot
added
size/M
Thor-wl
left a comment
Thor-wl
left a comment
There was a problem hiding this comment.
Thanks for the fix. Can you submit an issue about the details in order to make it easy for reviewers to have a full glimpse of the scenario?
Updated in the description. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
IC, it's just an optimization. |
3 participants
/kind bug
The problem here is we'll always return devIDs with length equals to 1, but actually I think
predicateGPUbyMemorywants to return all the available devIDs.volcano/pkg/scheduler/plugins/predicates/gpu.go
Lines 63 to 66 in 52a34f5