-
Notifications
You must be signed in to change notification settings - Fork 1.3k
add multi-arch image #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multi-arch image #2435
Conversation
5155e95 to
d2f159e
Compare
|
The tested multi-arch images, it works fine in my local envs:
The CI seems that the docker in minikube doesn't support buildkit? l tried but cannot figure it out, anyone knows how to avoid this? image links: https://hub.docker.com/u/cccccccjh |
shinytang6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementations LGTM overall. Need to pass the CI before merging
Yes, seems that |
|
If we want to support the buildx, we need install buildx to support on spark e2e test like: #2438 |
|
@ccchenjiahuan Thanks for your work! Feel free to squash #2438 in your pr, I did a e2e test with spark + buildx installation: #2438 , it works! |
|
and |
|
I also do a test manually in an arm64 env (apple M1): $ minikube start --cpus 4 --memory 6144
$ eval $(minikube docker-env)
$ make TAG=latest update-development-yaml
$ make TAG=latest images
$ k apply -f ~/code/volcano/installer/volcano-development.yaml
$ docker inspect volcanosh/vc-scheduler | grep Architecture
"Architecture": "arm64",
$ docker inspect volcanosh/vc-controller-manager | grep Architecture
"Architecture": "arm64",
$ docker inspect volcanosh/vc-webhook-manager | grep Architecture
"Architecture": "arm64",
$ k get pod -A | grep volcano
volcano-system volcano-admission-56d746f6d-kt4rd 1/1 Running 0 35m
volcano-system volcano-admission-init-5lnbt 0/1 Completed 0 35m
volcano-system volcano-controllers-7c79f98f4-5jxk2 1/1 Running 0 35m
volcano-system volcano-scheduler-598bfd9df4-bgdmr 1/1 Running 0 35mSpark e2e test also work: |
|
BTW, this might bring some behavior changes:
We'd better note in doc, release note or somewhere to mention them. And pls also fullfill the PR description to explain all user face behavior changes. : ) |
d2f159e to
e03cd77
Compare
Signed-off-by: ccchenjiahuan <[email protected]>
e03cd77 to
a0e1099
Compare
Thor-wl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM for me. Looking forward to other reviewers' advices.
shinytang6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, also LGTM
|
Another thing to check is whether the CI |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes. @ccchenjiahuan Can you submit another PR to update the doc? |
|
I tested this on m2 macbook air and and an amd64 virtual machine. It can work. |
|
btw, |
|
With this solution, each component will download the project's dependency package when it is built. If for some well-known reason, the download can easily fail due to network instability. In this case, it is difficult to successfully build images. :-P |
This pr has some notable changes:
installer/volcano-development-arm64.yamland arm specified images , because we don't need them anymoreSigned-off-by: ccchenjiahuan [email protected]