Skip to content

Conversation

@qiankunli
Copy link
Contributor

related pr #2227

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 13, 2022
@qiankunli qiankunli changed the title add details for nodegroup plugin add details for nodegroup doc Jul 13, 2022
Signed-off-by: qiankunli <[email protected]>
@qiankunli qiankunli force-pushed the feature/node-group-doc branch from 4164b4b to 5cefd2c Compare July 13, 2022 02:32
@volcano-sh-bot volcano-sh-bot added retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 13, 2022
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
@Thor-wl Thor-wl requested review from Thor-wl, shinytang6 and william-wang and removed request for merryzhou July 13, 2022 08:44
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@volcano-sh-bot volcano-sh-bot merged commit 729dca1 into volcano-sh:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants