Skip to content

Add pytorch plugin #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
volcano-sh-bot merged 3 commits into from
Jul 21, 2022
Merged

Add pytorch plugin #2313

volcano-sh-bot merged 3 commits into from
Jul 21, 2022

Conversation

@ccchenjiahuan
Copy link
Contributor

@ccchenjiahuan ccchenjiahuan commented Jun 27, 2022

No description provided.

@volcano-sh-bot
Copy link
Contributor

volcano-sh-bot commented Jun 27, 2022

Welcome @ccchenjiahuan!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 27, 2022
@ccchenjiahuan
add pytorch plugin
3e7aa2c 
Signed-off-by: ccchenjiahuan <[email protected]>
hwdef
hwdef reviewed Jun 27, 2022
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some e2e test.
And add a user guide in https://github.com/volcano-sh/volcano/tree/master/docs/user-guide
This plugin doesn't seem to be registered.

volcano/pkg/controllers/job/plugins/factory.go

Line 30 in 40b7fa7

func init() {

Thor-wl
Thor-wl reviewed Jun 27, 2022
View reviewed changes
Copy link
Contributor

@Thor-wl Thor-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! It makes sense a lot! BTW, Could you add some technology details in the design doc and a user guide under the folder

@ccchenjiahuan
Copy link
Contributor Author

ccchenjiahuan commented Jun 29, 2022

Please add some e2e test. And add a user guide in https://github.com/volcano-sh/volcano/tree/master/docs/user-guide This plugin doesn't seem to be registered.

volcano/pkg/controllers/job/plugins/factory.go

Line 30 in 40b7fa7

func init() {

thanks for the comments, l am trying to test with some examples and will come back once ready.

@ccchenjiahuan
Copy link
Contributor Author

ccchenjiahuan commented Jun 29, 2022

Thanks for your contribution! It makes sense a lot! BTW, Could you add some technology details in the design doc and a user guide under the folder

ok, l will add it

@Thor-wl
Copy link
Contributor

Thor-wl commented Jul 1, 2022

BTW, pls execute go fmt xxx to pass the code verify.

@hwdef
Copy link
Member

hwdef commented Jul 4, 2022

Do you have design documentation?

@ccchenjiahuan
Copy link
Contributor Author

ccchenjiahuan commented Jul 4, 2022

Do you have design documentation?

yes, I am preparing it, but there are some problems when testing pytorch example, I will upload it after all ready

@shinytang6
Copy link
Member

shinytang6 commented Jul 4, 2022

/hold

@volcano-sh-bot volcano-sh-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2022
@ccchenjiahuan ccchenjiahuan force-pushed the pytorch branch 7 times, most recently from 6b83dc9 to a79cefe Compare July 10, 2022 13:53
@ccchenjiahuan
add pytorch test file
d141084 
Signed-off-by: ccchenjiahuan <[email protected]>
@ccchenjiahuan
Copy link
Contributor Author

ccchenjiahuan commented Jul 10, 2022

Hi @hwdef @Thor-wl @shinytang6 , related comments have been added, could you help to review it again, thanks!

Thor-wl
Thor-wl reviewed Jul 11, 2022
View reviewed changes
@ccchenjiahuan
Copy link
Contributor Author

ccchenjiahuan commented Jul 14, 2022

hi @Thor-wl , l have fixed your comments, please help rerun the ci, thanks!

@shinytang6
Copy link
Member

shinytang6 commented Jul 18, 2022

/hold cancel

@volcano-sh-bot volcano-sh-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2022
@shinytang6
Copy link
Member

shinytang6 commented Jul 18, 2022

Please help review the PR again. @Thor-wl @hwdef

Thor-wl
Thor-wl reviewed Jul 19, 2022
View reviewed changes
Thor-wl
Thor-wl reviewed Jul 19, 2022
View reviewed changes
Copy link
Contributor

@Thor-wl Thor-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generally LGTM to me now. Thanks for your contribution! Looking forward to other reviewers' advice.

@Thor-wl
Copy link
Contributor

Thor-wl commented Jul 19, 2022

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2022
hwdef
hwdef reviewed Jul 19, 2022
View reviewed changes
@ccchenjiahuan
fix comments
0dd74cc 
Signed-off-by: ccchenjiahuan <[email protected]>
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2022
@volcano-sh-bot
Copy link
Contributor

volcano-sh-bot commented Jul 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2022
@volcano-sh-bot volcano-sh-bot merged commit 5f0a540 into volcano-sh:master Jul 21, 2022
@shinytang6 shinytang6 mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@qiankunli qiankunli Awaiting requested review from qiankunli

2 more reviewers

@hwdef hwdef hwdef left review comments

@Thor-wl Thor-wl Thor-wl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Thor-wl Thor-wl

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ccchenjiahuan @volcano-sh-bot @Thor-wl @hwdef @shinytang6