Skip to content

fix scheduler cache waitforcachesync #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
volcano-sh-bot merged 1 commit into from
Jul 5, 2022
Merged

fix scheduler cache waitforcachesync #2307

volcano-sh-bot merged 1 commit into from
Jul 5, 2022

Conversation

@xiaoanyunfei
Copy link
Contributor

@xiaoanyunfei xiaoanyunfei commented Jun 21, 2022

informerFactory.Start should be called before informerFactory.WaitForCacheSync ,and we can not make sure this in goroutine

I0621 11:02:51.566519 1 leaderelection.go:258] successfully acquired lease volcano-system/volcano
I0621 11:02:51.566961 1 scheduler.go:90] scheduler completes Initialization and start to run
I0621 11:02:51.567071 1 cache.go:1069] There are <0> Jobs, <0> Queues and <0> Nodes in total for scheduling.
I0621 11:02:51.567087 1 session.go:174] Open Session d9993fe3-f803-4865-a3bf-0e3423126f77 with <0> Job and <0> Queues
I0621 11:02:51.567322 1 enqueue.go:44] Enter Enqueue ...
I0621 11:02:51.567335 1 enqueue.go:78] Try to enqueue PodGroup to 0 Queues
I0621 11:02:51.567342 1 enqueue.go:103] Leaving Enqueue ...

@volcano-sh-bot volcano-sh-bot requested review from k82cn and zen-xu June 21, 2022 12:53
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2022
@xiaoanyunfei xiaoanyunfei force-pushed the bugfix/waitforcachesync branch from c0e37bb to a3cbba4 Compare June 21, 2022 12:54
@Thor-wl Thor-wl requested review from Thor-wl, qiankunli, shinytang6 and william-wang and removed request for k82cn and zen-xu June 22, 2022 01:38
@Thor-wl
Copy link
Contributor

Thor-wl commented Jul 5, 2022

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2022
@volcano-sh-bot
Copy link
Contributor

volcano-sh-bot commented Jul 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2022
@volcano-sh-bot volcano-sh-bot merged commit 61574b3 into volcano-sh:master Jul 5, 2022
@elinx
Copy link

elinx commented Jul 14, 2022

Thanks dude, you save my day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@william-wang william-wang Awaiting requested review from william-wang

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

@shinytang6 shinytang6 Awaiting requested review from shinytang6

@qiankunli qiankunli Awaiting requested review from qiankunli

Assignees

@Thor-wl Thor-wl

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiaoanyunfei @Thor-wl @volcano-sh-bot @elinx