Skip to content

fix(cli): Resolve bin/oxfmt as like oxlint#1326

Merged
graphite-app[bot] merged 1 commit into
mainfrom
04-07-fix_cli_resolve_bin_oxfmt_as_like_oxlint
Apr 7, 2026
Merged

fix(cli): Resolve bin/oxfmt as like oxlint#1326
graphite-app[bot] merged 1 commit into
mainfrom
04-07-fix_cli_resolve_bin_oxfmt_as_like_oxlint

Conversation

@leaysgur

@leaysgur leaysgur commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

We can avoid this issue by following the oxlint resolution approach. And now, it's ready to update [email protected] safely.

@netlify

netlify Bot commented Apr 7, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 4b8460f
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69d512385f723300086f8103

leaysgur commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur
leaysgur requested a review from fengmk2 April 7, 2026 08:55
@leaysgur

leaysgur commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

It seems that #1331 also covers this.

@fengmk2

fengmk2 commented Apr 7, 2026

Copy link
Copy Markdown
Member

@leaysgur I will merge your change first then let CC rerun #1331 again.

@graphite-app

graphite-app Bot commented Apr 7, 2026

Copy link
Copy Markdown

Merge activity

- `[email protected]` added `package.json` exports
  - oxc-project/oxc#20784, for #1162
- This prevents access to unspecified subpaths
- As a result, this type of error will occur
  - https://github.com/rolldown/rolldown/actions/runs/24068646976/job/70200159260?pr=9018
  - At the moment, `vite-plus` bundles `[email protected]`, so this should not be an issue
  - It was only causing a problem because rolldown repo happened to overwrite it by installing `[email protected]` separately
- However, this issue will happen for us when updating to bundle `[email protected]` in the future

We can avoid this issue by following the `oxlint` resolution approach. And now, it's ready to update `[email protected]` safely.
@graphite-app
graphite-app Bot force-pushed the 04-07-fix_cli_resolve_bin_oxfmt_as_like_oxlint branch from 55f2e37 to 4b8460f Compare April 7, 2026 14:18
@graphite-app
graphite-app Bot merged commit 4b8460f into main Apr 7, 2026
37 checks passed
@graphite-app
graphite-app Bot deleted the 04-07-fix_cli_resolve_bin_oxfmt_as_like_oxlint branch April 7, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants