refactor: remove PM fallback from vp run, always delegate to vite-plus

fengmk2 · fengmk2 · commit 3af4839e6597 · 2026-03-28T16:39:46.000+08:00
The `run_or_delegate` module previously fell back to `<pm> run <script>` when vite-plus was not a project dependency. This is no longer needed because the global CLI ships with its own vite-plus installation, and `delegate::execute()` already resolves local vite-plus first then falls back to the global one. Now `vp run` and `vpr` always delegate through the vite-plus task runner, regardless of whether the project has vite-plus as a dependency. Closes #1132
diff --git a/crates/vite_global_cli/src/cli.rs b/crates/vite_global_cli/src/cli.rs
@@ -1929,7 +1929,7 @@ pub async fn run_command_with_options(
                 return Ok(ExitStatus::default());
             }
             print_runtime_header(render_options.show_header);
-            commands::run_or_delegate::execute(cwd, &args).await
+            commands::delegate::execute(cwd, "run", &args).await
         }
 
         Commands::Exec { args } => {
diff --git a/crates/vite_global_cli/src/commands/mod.rs b/crates/vite_global_cli/src/commands/mod.rs
@@ -182,7 +182,6 @@ pub mod upgrade;
 
 // Category C: Local CLI Delegation
 pub mod delegate;
-pub mod run_or_delegate;
 
 // Re-export command structs for convenient access
 pub use add::AddCommand;
diff --git a/crates/vite_global_cli/src/commands/run_or_delegate.rs b/crates/vite_global_cli/src/commands/run_or_delegate.rs
diff --git a/crates/vite_global_cli/src/commands/vpr.rs b/crates/vite_global_cli/src/commands/vpr.rs
@@ -1,8 +1,7 @@
 //! `vpr` command implementation.
 //!
-//! Standalone shorthand for `vp run`. Executes tasks via the same
-//! run-or-delegate logic: delegates to local vite-plus CLI when
-//! vite-plus is a dependency, otherwise falls back to `<pm> run`.
+//! Standalone shorthand for `vp run`. Delegates to the local or global
+//! vite-plus CLI to execute tasks.
 
 use vite_path::AbsolutePath;
 use vite_shared::output;
@@ -16,7 +15,7 @@ pub async fn execute_vpr(args: &[String], cwd: &AbsolutePath) -> i32 {
     }
 
     let cwd_buf = cwd.to_absolute_path_buf();
-    match super::run_or_delegate::execute(cwd_buf, args).await {
+    match super::delegate::execute(cwd_buf, "run", args).await {
         Ok(status) => status.code().unwrap_or(1),
         Err(e) => {
             output::error(&e.to_string());
diff --git a/crates/vite_install/src/commands/mod.rs b/crates/vite_install/src/commands/mod.rs
@@ -20,7 +20,6 @@ pub mod prune;
 pub mod publish;
 pub mod rebuild;
 pub mod remove;
-pub mod run;
 pub mod search;
 pub mod token;
 pub mod unlink;
diff --git a/crates/vite_install/src/commands/run.rs b/crates/vite_install/src/commands/run.rs
diff --git a/packages/cli/snap-tests-global/command-run-without-vite-plus/snap.txt b/packages/cli/snap-tests-global/command-run-without-vite-plus/snap.txt
@@ -1,24 +1,18 @@
-> vp run hello # should fall back to pnpm run when no vite-plus dependency
+> vp run hello # should execute via global vite-plus task runner
 VITE+ - The Unified Toolchain for the Web
 
-
-> command-run-without-vite-plus@<semver> hello <cwd>
-> echo hello from script
-
+$ echo hello from script ⊘ cache disabled
 hello from script
 
-> vp run greet --arg1 value1 # should pass through args to pnpm run
-VITE+ - The Unified Toolchain for the Web
-
 
-> command-run-without-vite-plus@<semver> greet <cwd>
-> echo greet --arg1 value1
+> vp run greet --arg1 value1 # should pass through args
+VITE+ - The Unified Toolchain for the Web
 
+$ echo greet --arg1 value1 ⊘ cache disabled
 greet --arg1 value1
 
-[1]> vp run nonexistent # should show pnpm missing script error
-VITE+ - The Unified Toolchain for the Web
 
- ERR_PNPM_NO_SCRIPT  Missing script: nonexistent
+[1]> vp run nonexistent # should show task not found error
+VITE+ - The Unified Toolchain for the Web
 
-Command "nonexistent" not found.
+Task "nonexistent" not found.
diff --git a/packages/cli/snap-tests-global/command-run-without-vite-plus/steps.json b/packages/cli/snap-tests-global/command-run-without-vite-plus/steps.json
@@ -1,8 +1,7 @@
 {
-  "ignoredPlatforms": ["win32"],
   "commands": [
-    "vp run hello # should fall back to pnpm run when no vite-plus dependency",
-    "vp run greet --arg1 value1 # should pass through args to pnpm run",
-    "vp run nonexistent # should show pnpm missing script error"
+    "vp run hello # should execute via global vite-plus task runner",
+    "vp run greet --arg1 value1 # should pass through args",
+    "vp run nonexistent # should show task not found error"
   ]
 }
diff --git a/packages/cli/snap-tests-global/command-vpr/snap.txt b/packages/cli/snap-tests-global/command-vpr/snap.txt
@@ -31,21 +31,15 @@ Filter Patterns:
 Documentation: https://viteplus.dev/guide/run
 
 
-> vpr hello # should fall back to pnpm run when no vite-plus dependency
-
-> command-vpr@<semver> hello <cwd>
-> echo hello from script
-
+> vpr hello # should execute via global vite-plus task runner
+$ echo hello from script ⊘ cache disabled
 hello from script
 
-> vpr greet --arg1 value1 # should pass through args to pnpm run
-
-> command-vpr@<semver> greet <cwd>
-> echo greet --arg1 value1
 
+> vpr greet --arg1 value1 # should pass through args
+$ echo greet --arg1 value1 ⊘ cache disabled
 greet --arg1 value1
 
-[1]> vpr nonexistent # should show pnpm missing script error
- ERR_PNPM_NO_SCRIPT  Missing script: nonexistent
 
-Command "nonexistent" not found.
+[1]> vpr nonexistent # should show task not found error
+Task "nonexistent" not found.
diff --git a/packages/cli/snap-tests-global/command-vpr/steps.json b/packages/cli/snap-tests-global/command-vpr/steps.json
@@ -1,8 +1,8 @@
 {
   "commands": [
     "vpr -h # should show vp run help",
-    "vpr hello # should fall back to pnpm run when no vite-plus dependency",
-    "vpr greet --arg1 value1 # should pass through args to pnpm run",
-    "vpr nonexistent # should show pnpm missing script error"
+    "vpr hello # should execute via global vite-plus task runner",
+    "vpr greet --arg1 value1 # should pass through args",
+    "vpr nonexistent # should show task not found error"
   ]
 }
diff --git a/packages/cli/snap-tests-global/delegate-respects-default-node-version/snap.txt b/packages/cli/snap-tests-global/delegate-respects-default-node-version/snap.txt
@@ -6,12 +6,10 @@ VITE+ - The Unified Toolchain for the Web
 > vp run check-node # Should also use 22.12.0
 VITE+ - The Unified Toolchain for the Web
 
-
-> delegate-respects-default-node-version@<semver> check-node <cwd>
-> node -e "console.log(process.version)"
-
+$ node -e "console.log(process.version)" ⊘ cache disabled
 v<semver>
 
+
 > vp exec node -e "console.log(process.version)" # Should also use 22.12.0
 VITE+ - The Unified Toolchain for the Web
 
diff --git a/rfcs/run-without-vite-plus-dependency.md b/rfcs/run-without-vite-plus-dependency.md

Original file line number	Diff line number	Diff line change
`@@ -1929,7 +1929,7 @@ pub async fn run_command_with_options(`
`1929`	`1929`	`return Ok(ExitStatus::default());`
`1930`	`1930`	`}`
`1931`	`1931`	`print_runtime_header(render_options.show_header);`
`1932`		`- commands::run_or_delegate::execute(cwd, &args).await`
	`1932`	`+ commands::delegate::execute(cwd, "run", &args).await`
`1933`	`1933`	`}`
`1934`	`1934`
`1935`	`1935`	`Commands::Exec { args } => {`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,7 @@`
`1`	`1`	`{`
`2`		`- "ignoredPlatforms": ["win32"],`
`3`	`2`	`"commands": [`
`4`		`- "vp run hello # should fall back to pnpm run when no vite-plus dependency",`
`5`		`- "vp run greet --arg1 value1 # should pass through args to pnpm run",`
`6`		`- "vp run nonexistent # should show pnpm missing script error"`
	`3`	`+ "vp run hello # should execute via global vite-plus task runner",`
	`4`	`+ "vp run greet --arg1 value1 # should pass through args",`
	`5`	`+ "vp run nonexistent # should show task not found error"`
`7`	`6`	`]`
`8`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	`{`
`2`	`2`	`"commands": [`
`3`	`3`	`"vpr -h # should show vp run help",`
`4`		`- "vpr hello # should fall back to pnpm run when no vite-plus dependency",`
`5`		`- "vpr greet --arg1 value1 # should pass through args to pnpm run",`
`6`		`- "vpr nonexistent # should show pnpm missing script error"`
	`4`	`+ "vpr hello # should execute via global vite-plus task runner",`
	`5`	`+ "vpr greet --arg1 value1 # should pass through args",`
	`6`	`+ "vpr nonexistent # should show task not found error"`
`7`	`7`	`]`
`8`	`8`	`}`