Skip to content

New package: QMPlay2-18.07.03 #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Aug 2, 2018
Merged

New package: QMPlay2-18.07.03 #560

1 commit merged into from
Aug 2, 2018

Conversation

@abenson
Copy link
Contributor

@abenson abenson commented Jul 1, 2018

Closes #514

@jnbr
Copy link
Contributor

jnbr commented Jul 1, 2018

ffmpeg4 (#474) just got merged. I would delay this until there is a QMPlay2 which supports ffmpeg4.

@notramo notramo mentioned this pull request Jul 1, 2018
Closed
@notramo
Copy link

notramo commented Jul 3, 2018

@abenson there is a new release.

@abenson
Copy link
Contributor Author

abenson commented Jul 3, 2018

Nice, with the FFmpeg 4.x patches.

@abenson abenson changed the title New package: QMPlay2-18.04.01 New package: QMPlay2-18.07.03 Jul 3, 2018
ghost
ghost reviewed Jul 17, 2018
View reviewed changes
srcpkgs/QMPlay2/template Outdated
qt5-svg-devel qt5-tools-devel qt5-x11extras-devel taglib-devel"
short_desc="Video and audio player which can play most formats and codecs"
maintainer="Andrew Benson <[email protected]>"
license="GPL-3.0-or-later"
Copy link

@ghost ghost Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's LGPL-3.0-only

Copy link
Contributor Author

@abenson abenson Jul 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

srcpkgs/QMPlay2/template Outdated
license="GPL-3.0-or-later"
homepage="http://zaps166.sourceforge.net/?app=QMPlay2"
distfiles="https://github.com/zaps166/QMPlay2/archive/${version}.tar.gz"
checksum=e9dd6caa74e0824d950c0d11b2ed71e799f0a02c375b49ff635498133ab6b45e
Copy link

@ghost ghost Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://github.com/zaps166/QMPlay2/releases , the source tarball is:

distfiles="https://github.com/zaps166/QMPlay2/releases/download/${version}/QMPlay2-src-${version}.tar.xz"
checksum=78cdadea21728f7a902ae240aae15481bcad2b9f34598c20ee7711feeff79122

Copy link
Contributor Author

@abenson abenson Jul 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose the other one to avoid having to change wrksrc, but that one works fine

@Johnnynator
Copy link
Member

Johnnynator commented Jul 28, 2018 •
edited
Loading

It needs a patch for musl

[ 19%] Building CXX object src/qmplay2/CMakeFiles/libqmplay2.dir/libqmplay2_autogen/mocs_compilation.cpp.o
/builddir/QMPlay2-src-18.07.03/src/qmplay2/IPC_Unix.cpp: In member function 'virtual bool IPCSocket::open(QIODevice::OpenMode)':
/builddir/QMPlay2-src-18.07.03/src/qmplay2/IPC_Unix.cpp:101:9: error: 'u_long' does not name a type; did you mean 'ulong'?
   const u_long on = 1;
         ^~~~~~
         ulong
/builddir/QMPlay2-src-18.07.03/src/qmplay2/IPC_Unix.cpp:102:31: error: 'on' was not declared in this scope
   ioctl(m_priv->fd, FIONBIO, &on);
                               ^~

@abenson
Copy link
Contributor Author

abenson commented Jul 29, 2018

That was an easy fix. I PR'd it upstream, too

@notramo
Copy link

notramo commented Aug 2, 2018

@cr6git Could it be merged now?

@ghost ghost merged commit 4f4ee2d into void-linux:master Aug 2, 2018
@abenson abenson deleted the QMPlay2 branch March 20, 2021 19:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package request: QMPlay2

4 participants

@abenson @jnbr @notramo @Johnnynator