-
Notifications
You must be signed in to change notification settings - Fork 2.5k
dnscrypt-proxy: ensure log dir is present #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
should problably add logic to the runit service to make sure the logdir is available. mkdir -p /var/log/dnscrypt-proxy |
Contributor
|
also change the system account to match the other as _dnscrypt-proxy if possible. |
Member
Author
|
Contributor
|
On Sat, Jun 16, 2018 at 05:12:19AM -0700, Piraty wrote:
1. placing it in `run` file seems a good choice, but to my defence: i just followed example by some templates that only use `make_dirs` and not care in `run` (example: [dq](https://github.com/void-linux/void-packages/blob/master/srcpkgs/dq/template#L10))
2. chaning the system account will definetly require the `run` script to ensure correct owning
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#5 (comment)
1. make_dirs doesn't guarantee that the directories will stay that way so if you can use run files to guarantee that they stay with the correct permissions and owners it is a big plus.
2. i have been seeing a big switch to adding _ prefix to system accounts
|
Member
Get it merge 👍 |
Closed
Johnnynator
referenced
this pull request
in Johnnynator/void-packages
Jul 5, 2021
sysconf(_SC_GETPW_R_SIZE_MAX) may return −1 if there is no hard limit on the buffer size. Some libc implementations, e.g. musl libc, don't define this limit and will return -1. This fixes a bug where adb wait-for-usb-sideload would crash when the HOME environment variable is unset. Fixes #4 Fixes #5
zlice
pushed a commit
to zlice/void-packages
that referenced
this pull request
Oct 7, 2022
* Initial Linux/GCC support commit * Add instructins for linux in the README * apply suggestions by @Erotemic and @Emill * Fix python 3.10 symlink line * Fix func_80041E80 type mismatch (void-linux#3) Type mismatch functions.h:664 * Makefile: clean OTRExporter/libultraship/ZAPDTR with distclean and fix CXX_FILES * Makefile: find C/CXX_FILES automatically * Makefile: remove ugly conditions in find commands * cleanup _MSC_VER usage * fix Windows build * cleanup extraction scripts * fix Windows build * Fix Windows path separator issue * fix rumble support for linux * use glew-cmake in dockerfile * add pulseaudio backend * fix ZAPDTR linkage * Check for "soh.elf" in directory (void-linux#6) hide second button if `soh.exe` or `soh.elf` is present * Fix hardcoded segment addresses (void-linux#5) * fix condition * hack lus -> soh dep for ZAPDTR Co-authored-by: sholdee <[email protected]> Co-authored-by: qurious-pixel <[email protected]> Co-authored-by: GaryOderNichts <[email protected]>
Closed
robertek
added a commit
to robertek/void-packages
that referenced
this pull request
Jul 3, 2024
robertek
added a commit
to robertek/void-packages
that referenced
this pull request
Jul 3, 2024
greguu
added a commit
to greguu/voidz-packages
that referenced
this pull request
Mar 7, 2025
kevcrumb
pushed a commit
to kevcrumb/void-packages
that referenced
this pull request
Jun 24, 2025
The installer was originally written when the dhcpcd wpa_supplicant hook was enabled. In early 2019, the hook was disabled and it appears that the installer has been unable to configure WiFi since then. To address this, enable the wpa_supplicant service, configure it, and reload the service when dhcpcd is used for network connectivity. Closes void-linux#5 Also changes to a better file for checking if the network is working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.