common: support disabling python shebang rewriting #49886
Conversation
useful if there are special python-containing shebangs that should not be rewritten, for example with Ghidra's embedded jython.
ahesford
left a comment
ahesford
left a comment
There was a problem hiding this comment.
This seems like a good idea. We have several packages that ship example scripts that would probably be better left unmodified. During the next big Python bump, I'll try to remember to identify those and we can eliminate them from future update cycles.
maybe it would make sense to have this as a separate variable for patterns to ignore? python_shebang_ignore="/usr/libexec/ghidra/Ghidra/Features/Python/data/jython-2.7.3/*"for example edit: with the current hook, I'm not sure I see a way to do this without massively increasing the time spent running the hook. |
this solution feels very clean |
|
maybe, but it would require checking every path against (multiple) globs, from what i can tell, which could be slow |
3 participants
Ghidra's embedded jython contains scripts with shebangs like
#!/usr/bin/env python. These seem to be designed to be run by jython, not the system python, and as such, they should not have their shebangs changed to#!/usr/bin/python2. This adds support for disabling that hook in cases like this.Testing the changes