ffmpeg: update to 4.0.1. #474

jnbr · 2018-06-27T20:26:55Z

Local builds completed without error for i686, x86_64 and x86_64-musl so far.
I did some basic testing on x86_64.

jnbr · 2018-06-28T21:23:56Z

The remaining local builds for aarch64, armv7l and armv6l on both, glibc and musl, completed without error.

pullmoll · 2018-06-29T06:41:41Z

This PR looks good to me. I'd like to see some review from @void-linux/pkg-committers though.

jnbr · 2018-06-30T10:41:33Z

If someone want's to test this without building everything, packages are available here: https://jnbr.me/repo/ffmpeg/

pullmoll · 2018-06-30T14:02:31Z

FYI building this PR locally and will, if noone objects, push after a successful build.

pullmoll · 2018-06-30T17:38:06Z

transcode is missing from the list and it doesn't build out of the box, i.e. needs a patch.

ffmpeg_cfg.c:96:22: error: 'FF_DEFAULT_QUANT_BIAS' undeclared here (not in a function)…

I guess this is similar to other patches ~~and will try to create one~~ or rather not. There is a patch for ffmpeg3 which probably should be replaced with one for ffmpeg4 then.

I don't know which macros changed from 3 to 4 and how to go on from here. In case you have spare time I'd be happy to leave trying to patch that one to you :)

pullmoll · 2018-06-30T17:57:58Z

Also xpra is missing a revbump for ffmpeg-4.0.1. It seems to build without problems.

aescling · 2018-06-30T18:45:01Z

Shouldn't mpv be updated to 0.28.2?
Anyway I'm building it locally and seeing if it at least works on x86_64 glibc.

(Edit: it built fine)

jnbr · 2018-06-30T22:55:08Z

I added the bump for xpra and a patch from archlinux for transcode.

pullmoll · 2018-07-01T07:51:12Z

Thanks. It seems some more missing packages are libfreerdp, deepin-movie-reborn, deepin-music, deepin-voice-recorder and dolphin-emu. They are blocking the *-stagedata from being resolved here. Other than that the PR seems to build ok.

pullmoll · 2018-07-01T08:10:04Z

Ok, revbumping them seems sufficient to get my index updated again. phew :)

jnbr · 2018-07-01T08:40:32Z

deepin-movie-reborn fails for aarch64, checking the remaining ones currently. Also scrcpy and mgba were missing.

jnbr · 2018-07-01T10:25:02Z

I've set deepin-movie-reborn as broken for aarch64*. I don't get why it fails to link against ffmpegthumbnailer:

/builddir/.xbps-deepin-movie-reborn/wrappers/aarch64-linux-gnu-c++  -D_FORTIFY_SOURCE=2  -O2 -pipe -march=armv8-a -D_GLIBCXX_USE_CXX11_ABI=0  -I/usr/aarch64-linux-gnu/usr/include -std=c++11 -O3 -DNDEBUG  -Wl,-z,relro -Wl,-z,now -Wl,--as-needed     -L/usr/aarch64-linux-gnu/usr/lib -rdynamic CMakeFiles/deepin-movie.dir/common/actions.cpp.o CMakeFiles/deepin-movie.dir/common/dbus_adpator.cpp.o CMakeFiles/deepin-movie.dir/common/dmr_settings.cpp.o CMakeFiles/deepin-movie.dir/common/event_monitor.cpp.o CMakeFiles/deepin-movie.dir/common/event_relayer.cpp.o CMakeFiles/deepin-movie.dir/common/mainwindow.cpp.o CMakeFiles/deepin-movie.dir/common/options.cpp.o CMakeFiles/deepin-movie.dir/common/settings_translation.cpp.o CMakeFiles/deepin-movie.dir/common/shortcut_manager.cpp.o CMakeFiles/deepin-movie.dir/common/thumbnail_worker.cpp.o CMakeFiles/deepin-movie.dir/common/utility_x11.cpp.o CMakeFiles/deepin-movie.dir/widgets/burst_screenshots_dialog.cpp.o CMakeFiles/deepin-movie.dir/widgets/dmr_lineedit.cpp.o CMakeFiles/deepin-movie.dir/widgets/movie_progress_indicator.cpp.o CMakeFiles/deepin-movie.dir/widgets/movieinfo_dialog.cpp.o CMakeFiles/deepin-movie.dir/widgets/notification_widget.cpp.o CMakeFiles/deepin-movie.dir/widgets/playlist_widget.cpp.o CMakeFiles/deepin-movie.dir/widgets/slider.cpp.o CMakeFiles/deepin-movie.dir/widgets/tip.cpp.o CMakeFiles/deepin-movie.dir/widgets/titlebar.cpp.o CMakeFiles/deepin-movie.dir/widgets/toolbox_proxy.cpp.o CMakeFiles/deepin-movie.dir/widgets/toolbutton.cpp.o CMakeFiles/deepin-movie.dir/widgets/url_dialog.cpp.o CMakeFiles/deepin-movie.dir/libdmr/compositing_manager.cpp.o CMakeFiles/deepin-movie.dir/libdmr/dvd_utils.cpp.o CMakeFiles/deepin-movie.dir/libdmr/movie_configuration.cpp.o CMakeFiles/deepin-movie.dir/libdmr/online_sub.cpp.o CMakeFiles/deepin-movie.dir/libdmr/player_backend.cpp.o CMakeFiles/deepin-movie.dir/libdmr/player_engine.cpp.o CMakeFiles/deepin-movie.dir/libdmr/player_widget.cpp.o CMakeFiles/deepin-movie.dir/libdmr/playlist_model.cpp.o CMakeFiles/deepin-movie.dir/libdmr/utils.cpp.o CMakeFiles/deepin-movie.dir/main.cpp.o CMakeFiles/deepin-movie.dir/backends/mpv/mpv_glwidget.cpp.o CMakeFiles/deepin-movie.dir/backends/mpv/mpv_proxy.cpp.o CMakeFiles/deepin-movie.dir/qrc_resources.cpp.o CMakeFiles/deepin-movie.dir/deepin-movie_autogen/mocs_compilation.cpp.o  -o deepin-movie -lX11 -lXext -lXtst /usr/aarch64-linux-gnu/usr/lib/libQt5Widgets.so.5.10.1 /usr/aarch64-linux-gnu/usr/lib/libQt5X11Extras.so.5.10.1 /usr/aarch64-linux-gnu/usr/lib/libQt5Network.so.5.10.1 /usr/aarch64-linux-gnu/usr/lib/libQt5Concurrent.so.5.10.1 /usr/aarch64-linux-gnu/usr/lib/libQt5DBus.so.5.10.1 /usr/aarch64-linux-gnu/usr/lib/libQt5Sql.so.5.10.1 -lpthread -lGL -lffmpegthumbnailer -lpulse-simple -lpulse -lssl -lcrypto -ldvdnav -lpthread -lGL -lffmpegthumbnailer -lpulse-simple -lpulse -lssl -lcrypto -ldvdnav -lxcb-util -lxcb-ewmh -lxcb -lxcb-shape /usr/aarch64-linux-gnu/usr/lib/libQt5Gui.so.5.10.1 /usr/aarch64-linux-gnu/usr/lib/libQt5Core.so.5.10.1 -ldtkwidget -ldtkcore -lmpv -lavformat -lavutil -lavcodec -lavresample 
/usr/aarch64-linux-gnu/usr/lib/libQt5Network.so.5.10.1: warning: EVP_CipherFinal is often misused, please use EVP_CipherFinal_ex and EVP_CIPHER_CTX_cleanup
/usr/aarch64-linux-gnu/usr/lib/libQt5Network.so.5.10.1: warning: EVP_CipherFinal is often misused, please use EVP_CipherFinal_ex and EVP_CIPHER_CTX_cleanup
/usr/aarch64-linux-gnu/usr/lib/libQt5Network.so.5.10.1: warning: EVP_CipherFinal is often misused, please use EVP_CipherFinal_ex and EVP_CIPHER_CTX_cleanup
CMakeFiles/deepin-movie.dir/common/thumbnail_worker.cpp.o: In function `dmr::ThumbnailWorker::genThumb(QUrl const&, int)':
thumbnail_worker.cpp:(.text+0xdb4): undefined reference to `ffmpegthumbnailer::VideoThumbnailer::setSeekTime(std::string const&)'
thumbnail_worker.cpp:(.text+0xec0): undefined reference to `ffmpegthumbnailer::VideoThumbnailer::generateThumbnail(std::string const&, ThumbnailerImageTypeEnum, std::vector<unsigned char, std::allocator<unsigned char> >&, AVFormatContext*)'
CMakeFiles/deepin-movie.dir/libdmr/playlist_model.cpp.o: In function `dmr::PlaylistModel::calculatePlayInfo(QUrl const&, QFileInfo const&)':
playlist_model.cpp:(.text+0x555c): undefined reference to `ffmpegthumbnailer::VideoThumbnailer::generateThumbnail(std::string const&, ThumbnailerImageTypeEnum, std::vector<unsigned char, std::allocator<unsigned char> >&, AVFormatContext*)'
collect2: error: ld returned 1 exit status

Johnnynator · 2018-07-01T10:35:41Z

Mkay. That is the same issue that arm* has. I didn't have a clue what was going wrong when packageing deepin-movie-reborn and still don't have any.

pullmoll · 2018-07-01T10:36:10Z

mpd needs an update, as it was revbumped for libnfs.so.12.

jnbr · 2018-07-01T10:41:39Z

The ffmpegthumbnailer rebuild changed the symbol table, before it was:

/usr/aarch64-linux-gnu/usr/bin/objdump -TC /usr/aarch64-linux-gnu/usr/lib/libffmpegthumbnailer.so|grep setSeekTime
000000000000a7b4 g    DF .text	0000000000000008  Base        ffmpegthumbnailer::VideoThumbnailer::setSeekTime(std::string const&)

and the new one looks like this:

/usr/aarch64-linux-gnu/usr/bin/objdump -TC /usr/aarch64-linux-gnu/usr/lib/libffmpegthumbnailer.so.4|grep setSeekTime
000000000000a298 g    DF .text	0000000000000008  Base        ffmpegthumbnailer::VideoThumbnailer::setSeekTime(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)

Maybe that's a problem.

pullmoll · 2018-07-01T10:42:08Z

For deepin-movie-reborn perhaps the CXXFLAGS="-D_GLIBCXX_USE_CXX11_ABI=0" is the culprit.

[ci skip]

jnbr · 2018-07-01T10:47:19Z

I rebased and bumped mpd

Johnnynator · 2018-07-01T10:55:10Z

@pullmoll I added this flag to fix another issue, but yes it is the issue. I will revisit it once this PR is merged. (Or maybe earlier, at least it is a not critical issue)

pullmoll · 2018-07-01T18:12:27Z

@Johnnynator worked around it by not setting it for aarch64*, so at least aarch64 won't keep the *-stagedata forever.

Johnnynator · 2018-07-01T18:58:49Z

Ok. I forgot that it would cause a lot of staging on aarch64.

pullmoll · 2018-07-02T06:38:58Z

@chneukirchen aarch64* needs a host arch (x86_64) build of at least qt5 please.

pullmoll · 2018-07-02T09:31:34Z

Oops.. That revbump for handbrake was not necessary. I was misled by the missing "ffmpeg-4.0.1" name in the commit message ;-P

Gottox · 2018-07-02T09:54:57Z

@pullmoll just wait till x64_64 finishes, we restart the builder on aarch64 afterwards.

pullmoll · 2018-07-02T16:28:06Z

@Gottox does aarch64* now use the x86_64 repo? It used to build its own packages for the host.

Now the no longer existing kfilemetata package is keeping staged packages from being moved to the index. If kfilemetadata package cannot be removed, perhaps create a dummy symlink kfilemetadata5 -> kfilemetadata?

Gottox · 2018-07-02T16:53:02Z

Cleanup is in progress.

pullmoll · 2018-07-02T19:43:15Z

For kodi-rpi the patch is rather long. Here's what I have so far
I have no time to finish it now - need 🍻

jnbr · 2018-07-03T02:41:26Z

@pullmoll I added the missing bits for kodi-rpi: https://gist.github.com/jnbr/5206bde551ed259f29ae76c65154c3b7

pullmoll · 2018-07-03T04:41:48Z

Thank you @jnbr - I think that will fix arm* at least :)

jnbr force-pushed the ffmpeg branch from 7a5c742 to e723b3e Compare June 27, 2018 23:03

jnbr force-pushed the ffmpeg branch from 0bc4dc0 to ec994f6 Compare June 30, 2018 22:53

jnbr force-pushed the ffmpeg branch from ec994f6 to 917daac Compare July 1, 2018 08:45

jnbr added 11 commits July 1, 2018 12:44

ffmpeg: update to 4.0.1.

058c55b

alsa-plugins: rebuild for ffmpeg-4.0.1.

cc94095

libopenal: rebuild for ffmpeg-4.0.1.

d677c91

mlt: rebuild for ffmpeg-4.0.1.

c84115a

ffmpegthumbnailer: rebuild for ffmpeg-4.0.1.

07fc866

unpaper: rebuild for ffmpeg-4.0.1.

12e9344

pipewire: rebuild for ffmpeg-4.0.1.

666bca6

mpv: rebuild for ffmpeg-4.0.1.

92ce45e

osg: rebuild for ffmpeg-4.0.1.

8bf7e39

idjc: rebuild for ffmpeg-4.0.1.

1deccaf

minidlna: rebuild for ffmpeg-4.0.1.

c1ee5f5

jnbr added 13 commits July 1, 2018 12:44

gerbera: rebuild for ffmpeg-4.0.1.

82f3e82

libopenshot: add patch for ffmpeg-4.0.1.

98ffa7b

bomi: add patch for ffmpeg-4.0.1.

d28109f

[ci skip]

transcode: add patch for ffmpeg-4.0.1.

c8cb22c

xpra: rebuild for ffmpeg-4.0.1.

95b7819

[ci skip]

deepin-music: rebuild for ffmpeg-4.0.1.

6a28872

deepin-voice-recorder: rebuild for ffmpeg-4.0.1.

d025725

[ci skip]

mgba: rebuild for ffmpeg-4.0.1.

81255a3

freerdp: rebuild for ffmpeg-4.0.1.

f01f8d3

scrcpy: rebuild for ffmpeg-4.0.1.

b5aea6f

dolphin-emu: rebuild for ffmpeg-4.0.1.

d582b81

deepin-movie-reborn: rebuild for ffmpeg-4.0.1.

920628b

mpd: rebuild against ffmpeg-4.0.1.

393e4d9

[ci skip]

jnbr force-pushed the ffmpeg branch from 08938a2 to 393e4d9 Compare July 1, 2018 10:46

pullmoll closed this in 8813461 Jul 1, 2018

jnbr mentioned this pull request Jul 1, 2018

New package: QMPlay2-18.07.03 #560

Merged

jnbr deleted the ffmpeg branch July 19, 2018 15:17

emacsomancer mentioned this pull request Sep 8, 2020

picom: update to 8.1 #24762

Merged

ffmpeg: update to 4.0.1. #474

ffmpeg: update to 4.0.1. #474

Uh oh!

Conversation

jnbr commented Jun 27, 2018

Uh oh!

jnbr commented Jun 28, 2018

Uh oh!

pullmoll commented Jun 29, 2018

Uh oh!

jnbr commented Jun 30, 2018

Uh oh!

pullmoll commented Jun 30, 2018

Uh oh!

pullmoll commented Jun 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pullmoll commented Jun 30, 2018

Uh oh!

aescling commented Jun 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jnbr commented Jun 30, 2018

Uh oh!

pullmoll commented Jul 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pullmoll commented Jul 1, 2018

Uh oh!

jnbr commented Jul 1, 2018

Uh oh!

jnbr commented Jul 1, 2018

Uh oh!

Johnnynator commented Jul 1, 2018

Uh oh!

pullmoll commented Jul 1, 2018

Uh oh!

jnbr commented Jul 1, 2018

Uh oh!

pullmoll commented Jul 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jnbr commented Jul 1, 2018

Uh oh!

Johnnynator commented Jul 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pullmoll commented Jul 1, 2018

Uh oh!

Johnnynator commented Jul 1, 2018

Uh oh!

pullmoll commented Jul 2, 2018

Uh oh!

pullmoll commented Jul 2, 2018

Uh oh!

Gottox commented Jul 2, 2018

Uh oh!

pullmoll commented Jul 2, 2018

Uh oh!

Gottox commented Jul 2, 2018

Uh oh!

pullmoll commented Jul 2, 2018

Uh oh!

jnbr commented Jul 3, 2018

Uh oh!

pullmoll commented Jul 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pullmoll commented Jun 30, 2018 •

edited

Loading

aescling commented Jun 30, 2018 •

edited

Loading

pullmoll commented Jul 1, 2018 •

edited

Loading

pullmoll commented Jul 1, 2018 •

edited

Loading

Johnnynator commented Jul 1, 2018 •

edited

Loading