-
Notifications
You must be signed in to change notification settings - Fork 2.5k
android-studio: update to 2022.3.1.18, orphan #45676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have doubts:
For maintainer ship , I m not fully ready |
|
As described here, please add |
Optional dependencies should likely only be included if they're required for some fundamental features of the package - and I don't think that's the case here.
It seems to build just fine without using nopie, so I think it can be removed here. |
df8fe04 to
526b184
Compare
|
@Bnyro what about common/shlibs? |
|
I'm not really familiar with that, sorry. Looks fine to me, but you should not rely on me for that one. |
|
can you ping someone to review ? |
|
You can ask in the IRC room, it's linked in the Readme. |
|
@ahesford can you tell me about |
|
No libraries from this package should be mentioned in 'common/shlibs`. Please remove your additions as well as the existing entries that you intended to replace. |
|
@ahesford after deleting libs from would it possible to include compatibility for ncurses5 with current ncurses package (reference: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=ncurses5-compat-libs#n38) Or I skip dependency check for these following files (temporarily until ncurse5 is packages ) |
|
The inclusion of ncurses v5 compact libs has been discussed and rejected in the past. Skipping dependency checks for those two libraries is one possible workaround, but it may be better to remove those CPython extensions entirely (and anything that depends on them) because they will not be importable by Python. |
526b184 to
f881ea4
Compare
|
@ahesford , Lint template test fails edit: |
|
|
|
would simplelogin alias work here? |
|
You should use an email you have and keep access to, I'm not familiar with Simplelogin. |
f881ea4 to
ec93af9
Compare
|
lol same test was passed just before this commit |
|
Only a network error, can be ignored. |
should I force push again |
ec93af9 to
094ae00
Compare
Testing the changes
New package
Local build testing
This PR is based on #41215