Skip to content

Conversation

@Luciogi
Copy link
Contributor

@Luciogi Luciogi commented Aug 19, 2023

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

This PR is based on #41215

@Luciogi
Copy link
Contributor Author

Luciogi commented Aug 19, 2023

I have doubts:


For maintainer ship , I m not fully ready

@Bnyro
Copy link
Contributor

Bnyro commented Aug 20, 2023

As described here, please add , orphan to your commit message.

@Bnyro
Copy link
Contributor

Bnyro commented Aug 20, 2023

This package has optional dependency on ncurses5, though application works without it

Optional dependencies should likely only be included if they're required for some fundamental features of the package - and I don't think that's the case here.

Please tell is nopie option is required here

It seems to build just fine without using nopie, so I think it can be removed here.

@Luciogi
Copy link
Contributor Author

Luciogi commented Aug 20, 2023

@Bnyro what about common/shlibs?

@Bnyro
Copy link
Contributor

Bnyro commented Aug 20, 2023

I'm not really familiar with that, sorry.

Looks fine to me, but you should not rely on me for that one.

@Luciogi
Copy link
Contributor Author

Luciogi commented Aug 20, 2023

can you ping someone to review ?

@Bnyro
Copy link
Contributor

Bnyro commented Aug 20, 2023

You can ask in the IRC room, it's linked in the Readme.

@Bnyro
Copy link
Contributor

Bnyro commented Aug 20, 2023

@Luciogi
Copy link
Contributor Author

Luciogi commented Aug 20, 2023

@ahesford can you tell me about common/shlibs I dont understand which libs to include

@ahesford
Copy link
Member

No libraries from this package should be mentioned in 'common/shlibs`. Please remove your additions as well as the existing entries that you intended to replace.

@Luciogi
Copy link
Contributor Author

Luciogi commented Aug 20, 2023

@ahesford after deleting libs from common/shlibs breaks package build
https://pastebin.com/Ug5xKLHT
it seems now ncurses5 is required to build

would it possible to include compatibility for ncurses5 with current ncurses package (reference: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=ncurses5-compat-libs#n38)

Or I skip dependency check for these following files (temporarily until ncurse5 is packages )

./plugins/android-ndk/resources/lldb/lib/python3.10/lib-dynload/_curses.cpython-310-x86_64-linux-gnu.so
./plugins/android-ndk/resources/lldb/lib/python3.10/lib-dynload/_curses_panel.cpython-310-x86_64-linux-gnu.so

@ahesford
Copy link
Member

ahesford commented Aug 20, 2023

The inclusion of ncurses v5 compact libs has been discussed and rejected in the past. Skipping dependency checks for those two libraries is one possible workaround, but it may be better to remove those CPython extensions entirely (and anything that depends on them) because they will not be importable by Python.

@Luciogi Luciogi marked this pull request as ready for review August 21, 2023 06:16
@Luciogi
Copy link
Contributor Author

Luciogi commented Aug 21, 2023

@ahesford , Lint template test fails

edit: xlint template does not produce any error locally

@Bnyro
Copy link
Contributor

Bnyro commented Aug 21, 2023

authored by noreply email - you have to use a proper email for authoring the commit.

@Luciogi
Copy link
Contributor Author

Luciogi commented Aug 21, 2023

would simplelogin alias work here?

@Bnyro
Copy link
Contributor

Bnyro commented Aug 21, 2023

You should use an email you have and keep access to, I'm not familiar with Simplelogin.

@Luciogi
Copy link
Contributor Author

Luciogi commented Aug 21, 2023

lol same test was passed just before this commit

@Bnyro
Copy link
Contributor

Bnyro commented Aug 21, 2023

Only a network error, can be ignored.

@Luciogi
Copy link
Contributor Author

Luciogi commented Aug 21, 2023

Only a network error, can be ignored.

should I force push again
or reviewer will manually start checks ?

@Luciogi Luciogi changed the title android-studio: update to 2022.3.1.18 android-studio: update to 2022.3.1.18, orphan Aug 21, 2023
@classabbyamp classabbyamp merged commit bbebe57 into void-linux:master Sep 27, 2023
@Luciogi Luciogi deleted the android-studio branch March 6, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants