fmt: update to 9.0.0. #38916
Closed
fmt: update to 9.0.0. #38916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atweiden
reviewed
Aug 26, 2022
srcpkgs/cryfs/template
Outdated
| hostmakedepends="pkg-config python3" | ||
| makedepends="boost-devel fuse-devel libcurl-devel libgomp-devel crypto++-devel | ||
| spdlog" | ||
| spdlog range-v3" |
Contributor
There was a problem hiding this comment.
IIRC range-v3 can be in hostmakedepends, because it’s only used for code generation.
See: JamiKettunen@ffb2da4
atweiden
reviewed
Aug 26, 2022
| configure_args="-DCRYFS_UPDATE_CHECKS=off | ||
| -DBoost_USE_STATIC_LIBS=OFF -DCMAKE_CXX_STANDARD_LIBRARIES=-lfmt" | ||
| configure_args="-DCRYFS_UPDATE_CHECKS=off -DBoost_USE_STATIC_LIBS=OFF | ||
| -DCMAKE_CXX_STANDARD_LIBRARIES=-lfmt |
Contributor
There was a problem hiding this comment.
IIRC, -DCMAKE_CXX_STANDARD_LIBRARIES=-lfmt isn’t needed here unless you remove fmt-devel from makedepends.
Contributor
There was a problem hiding this comment.
I notice the cryfs template doesn’t have fmt-devel in makedepends presently. It probably should (see: cryfs/cryfs#432 (comment)).
atweiden
reviewed
Aug 26, 2022
| distfiles="https://github.com/cryfs/cryfs/releases/download/${version}/${pkgname}-${version}.tar.gz" | ||
| checksum=004c7fdf537062e197aaa0bcdafd2682904a279802441bb6063cb72c1fba52d2 | ||
| checksum=a89ab8fea2d494b496867107ec0a3772fe606ebd71ef12152fcd233f463a2c00 | ||
|
|
Contributor
There was a problem hiding this comment.
I recall builds failing without CXX_FLAGS="-pthread" here.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip]
Packages bumped and status: