offlineimap: update to 8.0.0; remove dispensable py2 deps #38781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inessential python2 remnant
Inessential python2 remnant
classabbyamp
added
needs-testing
Member
|
Do not merge without my approval please. |
Member
|
GitHub Actions doesn't do IPv6, please disable these tests too. |
Member
Author
|
Maybe I got the commit order wrong? Seemed okay to me but some builds are confused about not finding the |
Member
|
python3-imaplib2 needs to be in hostmakedepends too if it's needed during build |
Member
Author
|
Ah, everything under |
Member
|
Used it for three days, seems to work fine and even is a bit faster. |
leahneukirchen
removed
the
needs-testing
Member
|
@leahneukirchen still working well? can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
This update migrates the package to python 3. Two of the python 2 dependencies under the old full-deptree don't have any more dependent packages. I removed one of them outright. For the other, which provided a python 3 counterpart as subpackage, removed the python 2 package and converted the python 3 symlinked package to be its own module.
I DID NOT do any significant runtime testing on the updated
offlineimappackage expect for installing and running--version,--helpetc.