Skip to content

Conversation

@lemmi
Copy link
Member

@lemmi lemmi commented Jul 1, 2022

This got unnecessarily hard to package. But using the auto download just takes ages. The latest release is missing the 11 to 12 migration. So the version number isn't quite correct.
Anyway, I thought I make it available in case someone needs this to try #37561.

Testing the changes

  • I tested the changes in this PR: briefly

@CMB
Copy link
Contributor

CMB commented Sep 22, 2022

On musl x86_64, I couldn't get the fs-repo-11-to-12 migration to work.
It died with this:

panic: qtls.ClientHelloInfo doesn't match
goroutine 1 [running]:
github.com/marten-seemann/qtls-go1-15.init.0()
        /builddir/fs-repo-migrations-fs-repo-11-to-12-v1.0.2/fs-repo-11-to-12/vendor/github.com/marten-seemann/qtls-go1-15/unsafe.go:20 +0x132

@CMB
Copy link
Contributor

CMB commented Sep 22, 2022

I could also reproduce on glibc.
Looking into this a bit more, I think the cause is
that fs-repo-migrations is incompatible with Go 1.19.

@CMB CMB mentioned this pull request Dec 5, 2022
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Dec 22, 2022
@github-actions github-actions bot closed this Jan 5, 2023
@lemmi lemmi deleted the fs-repo-migrations branch July 25, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants