Skip to content

New package: rset-2.4#31003

Closed
olivia-fl wants to merge 2 commits intovoid-linux:masterfrom
olivia-fl:new-package-rset
Closed

New package: rset-2.4#31003
olivia-fl wants to merge 2 commits intovoid-linux:masterfrom
olivia-fl:new-package-rset

Conversation

@olivia-fl
Copy link
Copy Markdown

@olivia-fl olivia-fl commented May 20, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl (cross)
    • armv7l (cross)
    • armv6l-musl (cross)

@ericonr ericonr added the new-package This PR adds a new package label May 20, 2021
@olivia-fl
Copy link
Copy Markdown
Author

Oh, looks like I never ran the check commands locally, and missed a check dependency on wget. My bad!

@olivia-fl
Copy link
Copy Markdown
Author

Alright now I'm really not sure what's going on. These checks work fine locally. I'll take a closer look tomorrow when I have time.

@olivia-fl
Copy link
Copy Markdown
Author

Ah, figured it out. This is an upstream problem with rset that occurs when running the tests as root. I created an issue for it here: eradman/rset#14. For now I'm going to disable the checks, with a comment to see if the issue is resolved when updating to a newer version later.

checkdepends="ruby>=2.4 wget"
short_desc="Configure systems using using any scripting language"
maintainer="Benjamin Lee <[email protected]>"
license="GPL-3.0-or-later"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rset itself (build and installed binaries) uses the ISC license

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. Fixed

@olivia-fl
Copy link
Copy Markdown
Author

@ericonr can you approve this for a CI run?

@github-actions
Copy link
Copy Markdown

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 20, 2022
@olivia-fl
Copy link
Copy Markdown
Author

I'm updating this package to fix the lint error and bring it to the newest version (2.4), and have discovered that the webrick module was removed from the standard library in version 3.0. This module is required in order to run the tests for rset, so I'm going to make a separate PR to add it.

@olivia-fl olivia-fl marked this pull request as draft May 23, 2022 22:16
@olivia-fl olivia-fl changed the title New package: rset-2.1 New package: rset-2.4 May 23, 2022
@github-actions github-actions bot removed the Stale label May 24, 2022
@olivia-fl olivia-fl marked this pull request as ready for review May 24, 2022 20:05
@olivia-fl
Copy link
Copy Markdown
Author

Alright, I've batched the ruby-webrick package in with rset, since it is a dependency, and added a patch to use inetutils-hostname instead of hostname in the test, since rset is expecting BSD hostname, which supports the -s flag.

@github-actions
Copy link
Copy Markdown

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Aug 24, 2022
@github-actions github-actions bot closed this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-package This PR adds a new package Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants